soc: ironside: add min and max values for update #96972
Conversation
zephyrbot
added
platform: nRF
zephyrbot
requested review from
57300,
anangl,
bjarki-andreasen,
JarmouniA,
jaz1-nordic,
jonathannilsen,
karstenkoenig,
kartben,
kl-cruz,
lstnl,
magp-nordic,
masz-nordic,
nashif,
nika-nordic and
SebastianBoe
| config UPDATE_BLOB_ADDRESS | ||
| hex "Address of the update blob" | ||
| default 0xe100000 | ||
| default 0x0e100000 |
There was a problem hiding this comment.
Shall we use a kconfig range for documentation's sake and to detect misconfig earlier?
There was a problem hiding this comment.
I thought about the same, but was a bit reluctant as this is just the sample. But I'm open to it if anyone thinks that we should do it that way.
There was a problem hiding this comment.
(NB: Not feasible to have a range if we take these values from the MDK though...)
There was a problem hiding this comment.
Moved the defines to the header file and added a build assert to the sample.
soc/nordic/ironside/Kconfig
Outdated
| help | ||
| Maximum value of address passed to the update service. | ||
| The biggest update (USLOT) occupies 160kB, so this address is set so that a 160kB | ||
| update would still be within the limit of MRAM11 (0x0e200000). |
There was a problem hiding this comment.
Assuming we don't already, could we have this 160kB number in a header file somewhere, so that we could calculate MRAM11_START + MRAM11_SIZE - USLOT_MAX_SIZE ?
If we are not confident this 160kB number will be platform portable we could also #error-out when a new platform leaves it undefined. Something that is not as easy to do in Kconfig.
There was a problem hiding this comment.
Added this suggestion to the header file.
soc/nordic/ironside/update.c
Outdated
| int err; | ||
| struct ironside_call_buf *const buf = ironside_call_alloc(); | ||
|
|
||
| if ((uintptr_t)update < CONFIG_NRF_IRONSIDE_UPDATE_SERVICE_MIN_ADDRESS || |
There was a problem hiding this comment.
I assume the MDK defines the start address of MRAM11?
Then porting to new platforms would be easier I would think.
There was a problem hiding this comment.
The limit is not tied to MRAM11, so we cannot use MDK for this as it might differ across platforms.
There was a problem hiding this comment.
Its not tied to MRAM11.
soc/nordic/ironside/Kconfig
Outdated
|
|
||
| config NRF_IRONSIDE_UPDATE_SERVICE_MAX_ADDRESS | ||
| hex | ||
| default 0x0e1d8000 |
There was a problem hiding this comment.
does it give any value to make these depend on the update service kconfig?
There was a problem hiding this comment.
Moved to the header file.
hakonfam
force-pushed
the
add-min-max-ironside-update
branch
from
cfaaa99 to
625de6b
Compare
The update will fail if the address is outside of this range. This failure might trigger a bad state where the device is non-trivial to recover. Signed-off-by: Håkon Amundsen <[email protected]>
hakonfam
force-pushed
the
add-min-max-ironside-update
branch
from
625de6b to
f4ab165
Compare
|
The update will fail if the address is outside of this range. This failure might trigger a bad state where the device is non-trivial to recover.