Skip to content

Conversation

KajbaM
Copy link

@KajbaM KajbaM commented Oct 3, 2025

Summary

Replaces blinky animation in getting started guide with nicer image.

I was bothered by image animation in getting started guide documentation page.
My issue was that there is still protective film applied to eInk screen in animation.

I recreated the animation with protective film removed.

Copy link

github-actions bot commented Oct 3, 2025

Hello @KajbaM, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added area: Documentation size: XS A PR changing only a single line of code labels Oct 3, 2025
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, thanks for this, but tbh it's hard to justify adding over 500KB to the GitHub repo just for this :) I am guessing you can get to a much smaller file size using animated webp in which case we can maybe consider this for inclusion.

@KajbaM
Copy link
Author

KajbaM commented Oct 6, 2025

This is nice, thanks for this, but tbh it's hard to justify adding over 500KB to the GitHub repo just for this :) I am guessing you can get to a much smaller file size using animated webp in which case we can maybe consider this for inclusion.

Yes! Absolutely agree, didn't initially notice change in size until CI started complaining about it :)
Original PNG seems much more compressed and original tool I used had problems with generating small output.
I played around a bit and managed to reduce size to match original file, still looking if that is possible any further.

Replace blinky animation in getting started guide with nicer image.

Signed-off-by: Matjaz Kajba <[email protected]>
@KajbaM KajbaM force-pushed the doc/update-blinky-img branch from 0e2066f to 8769a7c Compare October 9, 2025 07:55
Copy link

sonarqubecloud bot commented Oct 9, 2025

@KajbaM KajbaM requested a review from kartben October 9, 2025 11:02
@KajbaM
Copy link
Author

KajbaM commented Oct 9, 2025

@kartben I regenerated the image with some compression added which reduced the size significantly.
Is this acceptable size or should I deal with this further?

@kartben
Copy link
Contributor

kartben commented Oct 9, 2025

@kartben I regenerated the image with some compression added which reduced the size significantly. Is this acceptable size or should I deal with this further?

Yeah it's still quite large though

ffmpeg -i input.png  -vf "scale=400:-1" -loop 0 -lossless 0 -quality 90 -compression_level 6 output.webp

44 KB seems much more reasonable :) also leveraging the fact that it's 400px wide in the documentation page anyway so might as well resize the image accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Documentation size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants