-
Notifications
You must be signed in to change notification settings - Fork 8k
doc: replace getting started guide image #96974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello @KajbaM, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thanks for this, but tbh it's hard to justify adding over 500KB to the GitHub repo just for this :) I am guessing you can get to a much smaller file size using animated webp in which case we can maybe consider this for inclusion.
Yes! Absolutely agree, didn't initially notice change in size until CI started complaining about it :) |
Replace blinky animation in getting started guide with nicer image. Signed-off-by: Matjaz Kajba <[email protected]>
0e2066f
to
8769a7c
Compare
|
@kartben I regenerated the image with some compression added which reduced the size significantly. |
Yeah it's still quite large though
44 KB seems much more reasonable :) also leveraging the fact that it's 400px wide in the documentation page anyway so might as well resize the image accordingly. |
Summary
Replaces blinky animation in getting started guide with nicer image.
I was bothered by image animation in getting started guide documentation page.
My issue was that there is still protective film applied to eInk screen in animation.
I recreated the animation with protective film removed.