samples: i2s_codec: Refine i2s_codec sample #96976
Open
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZhaoxiangJin
commented
Oct 3, 2025
ZhaoxiangJin
commented
- Configure BLOCK count by using kconfig option 'EXTRA_BLOCKS' instad of fixed value. This allows user to customize the RAM usage based on their platform.
- Keep the PCM data in flash to avoid large RAM usage.
- Refine the sample to get the SAMPLE_BIT_WIDTH and BYTES_PER_SAMPLE from Kconfig options.
|
Hello @TomasBarakNXP, @VitekST, please help review. Thanks. |
This was referenced Oct 3, 2025
hakehuang
reviewed
Oct 5, 2025
| 0xc3, 0xc8, 0xc8, 0xc8, 0xc8, 0x38, 0xcf, 0x38, 0xcf, 0x1c, 0xd7, 0x1c, 0xd7, 0x37, 0xe0, | ||
| 0x37, 0xe0, 0x45, 0xea, 0x45, 0xea, 0xf8, 0xf4, 0xf8, 0xf4}; | ||
| const unsigned int __16kHz16bit_stereo_sine_pcm_len = sizeof(__16kHz16bit_stereo_sine_pcm); | ||
| static const unsigned int __16kHz16bit_stereo_sine_pcm_len = sizeof(__16kHz16bit_stereo_sine_pcm); |
| int "Extra block size" | ||
| default 32 | ||
| help | ||
| Count of DMIC channels to capture and process. |
There was a problem hiding this comment.
Is this really the count of DMIC channels?
ZhaoxiangJin
force-pushed
the
refine-i2s-codec-example
branch
from
3f5e03a to
a587e39
Compare
- Configure BLOCK count by using kconfig option 'EXTRA_BLOCKS' instad of fixed value. This allows user to customize the RAM usage based on their platform. - Keep the PCM data in flash to avoid large RAM usage. - Refine the sample to get the SAMPLE_BIT_WIDTH and BYTES_PER_SAMPLE from Kconfig options. Signed-off-by: Zhaoxiang Jin <[email protected]>
ZhaoxiangJin
force-pushed
the
refine-i2s-codec-example
branch
from
a587e39 to
dd50879
Compare
|
Update: |
|
hakehuang
approved these changes
Oct 7, 2025
| 0xc3, 0xc8, 0xc8, 0xc8, 0xc8, 0x38, 0xcf, 0x38, 0xcf, 0x1c, 0xd7, 0x1c, 0xd7, 0x37, 0xe0, | ||
| 0x37, 0xe0, 0x45, 0xea, 0x45, 0xea, 0xf8, 0xf4, 0xf8, 0xf4}; | ||
| const unsigned int __16kHz16bit_stereo_sine_pcm_len = sizeof(__16kHz16bit_stereo_sine_pcm); | ||
| static const unsigned int __16kHz16bit_stereo_sine_pcm_len = |
There was a problem hiding this comment.
const is probably not necessary here. See the reported issue: when cast to (void *) in main.c, const is lost.
anangl
reviewed
Oct 7, 2025
| them and the codec will be expected to consume them. | ||
|
|
||
| config EXTRA_BLOCKS | ||
| int "Extra block size" |
There was a problem hiding this comment.
Suggested change
| int "Extra block size" | |
| int "Number of extra blocks" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.