Skip to content

dts: pm: Add wakeup-signal property #96996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dts: pm: Add wakeup-signal property #96996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b9eee
dts: pm: Add wakeup-signal property
mmahadevan108 Oct 3, 2025
0cdea63
drivers: timer: Enable NXP LPTMR as wakeup-source
mmahadevan108 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/timer/mcux_lptmr_timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ static int sys_clock_driver_init(void)
LPTMR_SetTimerPeriod(LPTMR_BASE, CYCLES_PER_TICK);
LPTMR_StartTimer(LPTMR_BASE);

#if (DT_INST_PROP(0, wakeup_source))
/* Use wakeup-signal property if specified, else use the irq number */
NXP_ENABLE_WAKEUP_SIGNAL(DT_INST_PROP_OR(0, wakeup_signal, DT_INST_IRQN(0)));
Copy link
Member

@decsny decsny Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not enough value proposition being shown here to justify to be adding this property IMO. You are providing this value to a vendor specific macro. If we add this property it will become sticky and if people start using it and it turns out not to be very useful and becomes a technical debt when we decide some other way to do something, I don't want to add it. It's not thought through and seems rushed, and for what goal exactly I don't quite understand, I'm not seeing what it buys us.

Copy link
Member

@decsny decsny Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I can see it being fulfilled more generically and doing away with this vendor macro by my #93838 if you think of it as a one bit multiplexor

#endif
return 0;
}

Expand Down
2 changes: 2 additions & 0 deletions dts/arm/nxp/nxp_mcxw7x_common.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@
prescaler = <1>;
resolution = <32>;
status = "disabled";
wakeup-source;
wakeup-signal = <0>;
};

lptmr1: timer@2e000 {
Expand Down