Skip to content

modbus: serial: use gpio_dt_spec pointer-based API #97008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

modbus: serial: use gpio_dt_spec pointer-based API #97008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc71b5
modbus: serial: use `gpio_pin_set_dt()` for de/re pin control
ndrs-pst Oct 4, 2025
e21d1d2
modbus: serial: use `gpio_is_ready_dt()` for GPIO readiness check
ndrs-pst Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions subsys/modbus/modbus_serial.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static void modbus_serial_tx_on(struct modbus_context *ctx)
struct modbus_serial_config *cfg = ctx->cfg;

if (cfg->de != NULL) {
gpio_pin_set(cfg->de->port, cfg->de->pin, 1);
gpio_pin_set_dt(cfg->de, 1);
}

if (IS_ENABLED(CONFIG_MODBUS_SERIAL_ASYNC_API)) {
Expand All @@ -58,7 +58,7 @@ static void modbus_serial_tx_off(struct modbus_context *ctx)
}

if (cfg->de != NULL) {
gpio_pin_set(cfg->de->port, cfg->de->pin, 0);
gpio_pin_set_dt(cfg->de, 0);
}
}

Expand All @@ -78,7 +78,7 @@ static void modbus_serial_rx_on(struct modbus_context *ctx)
struct modbus_serial_config *cfg = ctx->cfg;

if (cfg->re != NULL) {
gpio_pin_set(cfg->re->port, cfg->re->pin, 1);
gpio_pin_set_dt(cfg->re, 1);
}

atomic_set_bit(&ctx->state, MODBUS_STATE_RX_ENABLED);
Expand Down Expand Up @@ -108,7 +108,7 @@ static void modbus_serial_rx_off(struct modbus_context *ctx)
atomic_clear_bit(&ctx->state, MODBUS_STATE_RX_ENABLED);

if (cfg->re != NULL) {
gpio_pin_set(cfg->re->port, cfg->re->pin, 0);
gpio_pin_set_dt(cfg->re, 0);
}
}

Expand Down Expand Up @@ -509,7 +509,7 @@ static int configure_gpio(struct modbus_context *ctx)
struct modbus_serial_config *cfg = ctx->cfg;

if (cfg->de != NULL) {
if (!device_is_ready(cfg->de->port)) {
if (!gpio_is_ready_dt(cfg->de)) {
return -ENODEV;
}

Expand All @@ -520,7 +520,7 @@ static int configure_gpio(struct modbus_context *ctx)


if (cfg->re != NULL) {
if (!device_is_ready(cfg->re->port)) {
if (!gpio_is_ready_dt(cfg->re)) {
return -ENODEV;
}

Expand Down