smf: simplify get_child_of() loop and rename local variable #97030
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenn-andrews
previously approved these changes
Oct 5, 2025
keith-zephyr
reviewed
Oct 7, 2025
vlad-kulikov
force-pushed
the
smf/refactor-get-child-of
branch
2 times, most recently
from
52cfef4 to
0c0334a
Compare
keith-zephyr
reviewed
Oct 7, 2025
Replace the open-ended while(true) with a null-terminated parent walk. Improves readability, behavior is unchanged. Signed-off-by: Vlad Kulikov <[email protected]>
vlad-kulikov
force-pushed
the
smf/refactor-get-child-of
branch
from
0c0334a to
ba4b91c
Compare
|
keith-zephyr
approved these changes
Oct 7, 2025
glenn-andrews
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the open-ended while(true) loop with a null-terminated walk and
use a more descriptive local name ('state' instead of 'tmp').
Improves readability, behavior is unchanged.