hap_ha: initial broadcast_sink #97042
Conversation
samples/bluetooth/hap_ha/src/main.c
Outdated
There was a problem hiding this comment.
I recommend that we remove these two empty lines
samples/bluetooth/hap_ha/src/main.c
Outdated
There was a problem hiding this comment.
Since we only more ad data and a call to init_bap_sink (an api call that should handle its own dependencies), I have a hard time to understand why all these new includes are needed. We should probably take a look and see which ones we dont need to add here :)
There was a problem hiding this comment.
Why did we add this? I cant see this function implementation added
There was a problem hiding this comment.
it also seems to be a copy'n'paste thing (look below)
There was a problem hiding this comment.
The static here was removed so that it could be reached in bap_broadcast_snk.c as I understand. Since default_conn is only used for NULL checks there, I would suggest to see if it makes sense to replace those checks with api calls to bap_unicast_sr.c instead, since default_conn "belongs" to this file.
There was a problem hiding this comment.
I have changed it back.
Now it's called over the bap_unicast_sr.h - which refs bap_unicast_sr_has_connection.
I don't know if that is what you had in mind.
Please provide feedback, so i can adjust it to a better solution. :)
There was a problem hiding this comment.
Since a lot of this code has been copied, the original Copyright note must be here as well, all the notices from the original file(s).
| endchoice # HAP_HA_HEARING_AID_LOCATION | ||
|
|
||
| endmenu | ||
| endmenu |
There was a problem hiding this comment.
missing newline - but in any case... now there are no real changes to the file, so maybe just discard it from the commit?
There was a problem hiding this comment.
forced pushed
I'm not sure why it stays? As i believe it has been adjusted back.
There was a problem hiding this comment.
the last line has a space removed
There was a problem hiding this comment.
That does give an error with the checkpatch.
Should i just ignore that? : )
rasmushoeg
force-pushed
the
add_bass_to_hap_ha
branch
from
d2b8067 to
fea7ec7
Compare
This PR adds the initial base functionality of the broadcast sink. The functionality is test on a NRF5340 audio. Signed-off-by: Rasmus Moeller <[email protected]>
rasmushoeg
force-pushed
the
add_bass_to_hap_ha
branch
from
fea7ec7 to
482841b
Compare
|
This PR introduces the initial version of the bap_broadcast_snk.c module, which implements the Bluetooth Basic Audio Profile (BAP) broadcast sink functionality.
Key features:
Handles PA sync, BASE reception, BIS sync, and stream lifecycle
Integrates with broadcast assistant and scan delegator callbacks
Prepares the system for future thread-based state machine integration
This module is foundational for receiving and processing Broadcast Isochronous Streams (BIS) in BAP.