testsuite: Make CONFIG_COVERAGE_DUMP_PATH_EXCLUDE depend on libc support #97148
Conversation
PR zephyrproject-rtos#94029 introduced a feature to filter out certain file paths from coverage dumps using the `fnmatch` function. Unfortauntely, this function is not universally implemented among all of Zephyr's libc options, particularly minimal libc. This causes build failures when libc support for `fnmatch()` is absent. Update Kconfig with a `depends on` clause and a helper symbol that guards the fnmatch header and function call when not enabled. Signed-off-by: Tristan Honscheid <[email protected]>
zephyrbot
requested review from
aaronemassey,
asemjonovs,
jeremybettis,
nashif and
yperess
|
| config COVERAGE_DUMP_PATH_EXCLUDE | ||
| string "Exclude files matching this pattern from the coverage data" | ||
| default "" | ||
| depends on !MINIMAL_LIBC |
There was a problem hiding this comment.
I could use some assistance with finding the correct condition(s) to put here. MINIMAL_LIBC does not support it. I don't think newlib does either, but not certain. For an external libc, I don't know if there is any way to tell...
There was a problem hiding this comment.
Alternatively, we could not bother with checking which libc and leave it up to the developer to ensure fnmatch is provided if they require this new feature. The helper symbol HAVE_COVERAGE_DUMP_PATH_EXCLUDE causes the references to be guarded when the feature is not used (i.e. the path is an empty string), which limits the build error to just cases where a developer tries using COVERAGE_DUMP_PATH_EXCLUDE and does not have fnmatch().
4 participants
PR #94029 introduced a feature to filter out certain file paths from coverage dumps using the
fnmatchfunction. Unfortauntely, this function is not universally implemented among all of Zephyr's libc options, particularly minimal libc. This causes build failures when libc support forfnmatch()is absent.Update Kconfig with a
depends onclause and a helper symbol that guards the fnmatch header and function call when not enabled.