Skip to content

drivers: tdk: Define the trigger as a pointer to allow dereferencing within the trigger handler callback. #97151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

drivers: tdk: Define the trigger as a pointer to allow dereferencing within the trigger handler callback. #97151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/sensor/tdk/icm45686/icm45686.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ struct icm45686_triggers {
const struct device *dev;
struct k_mutex lock;
struct {
struct sensor_trigger trigger;
const struct sensor_trigger *trigger;
sensor_trigger_handler_t handler;
} entry;
#if defined(CONFIG_ICM45686_TRIGGER_OWN_THREAD)
Expand Down
4 changes: 2 additions & 2 deletions drivers/sensor/tdk/icm45686/icm45686_trigger.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static void icm45686_thread_cb(const struct device *dev)
(void)k_mutex_lock(&data->triggers.lock, K_FOREVER);

if (data->triggers.entry.handler) {
data->triggers.entry.handler(dev, &data->triggers.entry.trigger);
data->triggers.entry.handler(dev, data->triggers.entry.trigger);
}

(void)k_mutex_unlock(&data->triggers.lock);
Expand Down Expand Up @@ -113,7 +113,7 @@ int icm45686_trigger_set(const struct device *dev,

switch (trig->type) {
case SENSOR_TRIG_DATA_READY:
data->triggers.entry.trigger = *trig;
data->triggers.entry.trigger = trig;
data->triggers.entry.handler = handler;

if (handler) {
Expand Down