Skip to content

drivers: serial: various improvements to the BFLB uart driver. #97153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2025
Merged

drivers: serial: various improvements to the BFLB uart driver. #97153

merged 3 commits into from
Oct 10, 2025
+77 −21

Conversation

VynDragon
Copy link
Contributor

  • Introduce De-init
  • Introduce Runtime configuration.

@zephyrbot zephyrbot added platform: Bouffalo Lab area: UART Universal Asynchronous Receiver-Transmitter labels Oct 7, 2025
@zephyrbot zephyrbot requested review from dcpleung and josuah October 7, 2025 20:14
josuah
josuah previously approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 2nd chip family implementing _DEINIT APIs!

@josuah
Copy link
Contributor

josuah commented Oct 7, 2025

Some unused variable on CI due to the #ifdef... show that at least this driver runs well on CI

/__w/zephyr/zephyr/drivers/serial/uart_bflb.c:455:35: error: unused variable 'cfg' [-Werror=unused-variable]
  455 |         const struct bflb_config *cfg = dev->config;
      |                                   ^~~

@VynDragon
Copy link
Contributor Author

Some unused variable on CI due to the #ifdef... show that at least this driver runs well on CI

/__w/zephyr/zephyr/drivers/serial/uart_bflb.c:455:35: error: unused variable 'cfg' [-Werror=unused-variable]
  455 |         const struct bflb_config *cfg = dev->config;
      |                                   ^~~

Ah well i didnt catch that one...

@VynDragon
drivers: serial: Add De-init to bflb uart driver
7966a5f 
Allows BFLB uart peripheral to de-init.

Signed-off-by: Camille BAUD <[email protected]>
@josuah josuah self-requested a review October 7, 2025 22:15
@kartben kartben requested a review from Copilot October 8, 2025 04:44
Copilot
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces de-initialization functionality and runtime configuration support to the BFLB UART driver. The changes enable dynamic UART parameter configuration during runtime rather than only at compile time.

  • Moved UART configuration parameters from static config structure to runtime data structure
  • Added runtime configuration API support with configure and config_get functions
  • Introduced de-initialization function to properly clean up UART resources

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

drivers/serial/uart_bflb.c
.flow_ctrl = UART_FLOWCTRL_NONE, \
/* overflow interrupt threshold, size is 32 bytes*/ \
.tx_fifo_threshold = 8, \
.tx_fifo_threshold = 16, \
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tx_fifo_threshold value was changed from 8 to 16 without explanation. This change should either be documented in the commit message or reverted if it's unintentional, as it could affect UART transmission behavior.

Suggested change
.tx_fifo_threshold = 16, \
.tx_fifo_threshold = 8, \

Copilot uses AI. Check for mistakes.

Copy link
Contributor

@kartben kartben Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a fair comment and at least it would be worth having this change as a separate commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@VynDragon
drivers: serial: Improve BFLB UART driver: add runtime configuration
07a58aa 
This adds the ability to do runtime configuration of the BFLB
UART driver.

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
drivers: serial: increase FIFO threshold for BFLB uart driver
36f1ff1 
Increases the fifo threshold for tx, should increase speed a bit.

Signed-off-by: Camille BAUD <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt merged commit 6430ad4 into zephyrproject-rtos:main Oct 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@kartben kartben kartben approved these changes

@josuah josuah josuah approved these changes

@dcpleung dcpleung Awaiting requested review from dcpleung

Assignees

@VynDragon VynDragon

Labels
area: UART Universal Asynchronous Receiver-Transmitter platform: Bouffalo Lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VynDragon @josuah @kartben @cfriedt @zephyrbot