Skip to content

Conversation

JordanYates
Copy link
Contributor

Rename the bq25180 implementation and files to the more generic bq2518x. This charger family contains the bq25180, bq25186, bq25188 and the standalone (non-I2C) bq25185.

The register maps are practically identical, so the driver should be re-used.

Rename the bq25180 implementation and files to the more generic bq2518x.
This charger family contains the bq25180, bq25186, bq25188 and the
standalone (non-I2C) bq25185.

The register maps are practically identical, so the driver should be
re-used.

Signed-off-by: Jordan Yates <[email protected]>
Add support for the bq25186 and bq25188 chip variants.

Signed-off-by: Jordan Yates <[email protected]>
Add the `ti,bq25186` and `ti,bq25188`` to the build all test.

Signed-off-by: Jordan Yates <[email protected]>
Instead of text in the description that specifies the valid values,
add the `enum` property so values are validated at compile time.

Signed-off-by: Jordan Yates <[email protected]>
Add configuration for the VSYS target regulation voltage.

Explicitly specify the threshold at which charging will resume, instead
of deriving it from the combination of two devicetree properties which
have no compile-time validation.

Simplify the process of initialising the chip by precomputing the
register values and explicitly writing the whole register, instead of
updating multiple fields individually.

Signed-off-by: Jordan Yates <[email protected]>
@zephyrbot zephyrbot added platform: TI SimpleLink Texas Instruments SimpleLink MCU area: Devicetree Bindings area: Tests Issues related to a particular existing or missing test area: Boards/SoCs area: Charger labels Oct 8, 2025
Copy link

sonarqubecloud bot commented Oct 8, 2025

@rriveramcrus
Copy link
Contributor

Hello @JordanYates,

Thank you for your contribution! Some of this PR duplicates the efforts of #95727 and some of this PR introduces new functionality and improvements. If it's alright with you let's try and get #95727 merged first and then we can rebase some of what you've put together and continue this PR.

By the way your feedback is welcome on #95727 as you're probably pretty familiar with the device.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/power/supply/gpio-charger.c?h=v6.17
One last point from me is that I always envisioned standalone charger devices sharing a common GPIO charger driver as was done in the linux kernel. I'd be curious about your thoughts on this idea.

@JordanYates
Copy link
Contributor Author

I wasn't aware of the other PR or I would have based my work on top of that.
Is there anything that PR does that this PR doesn't do?
I ask because updating the latter half of this PR to work with #95727 instead of the first half of this PR is not 0 effort.
I don't want to downplay the effort invested in #95727 (or take any credit) but IMO we would have more features with less effort by just using this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards/SoCs area: Charger area: Devicetree Bindings area: Tests Issues related to a particular existing or missing test platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants