-
Notifications
You must be signed in to change notification settings - Fork 8k
charger: add bq2518x variants #97157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Rename the bq25180 implementation and files to the more generic bq2518x. This charger family contains the bq25180, bq25186, bq25188 and the standalone (non-I2C) bq25185. The register maps are practically identical, so the driver should be re-used. Signed-off-by: Jordan Yates <[email protected]>
Add support for the bq25186 and bq25188 chip variants. Signed-off-by: Jordan Yates <[email protected]>
Add the `ti,bq25186` and `ti,bq25188`` to the build all test. Signed-off-by: Jordan Yates <[email protected]>
Instead of text in the description that specifies the valid values, add the `enum` property so values are validated at compile time. Signed-off-by: Jordan Yates <[email protected]>
Add configuration for the VSYS target regulation voltage. Explicitly specify the threshold at which charging will resume, instead of deriving it from the combination of two devicetree properties which have no compile-time validation. Simplify the process of initialising the chip by precomputing the register values and explicitly writing the whole register, instead of updating multiple fields individually. Signed-off-by: Jordan Yates <[email protected]>
|
Hello @JordanYates, Thank you for your contribution! Some of this PR duplicates the efforts of #95727 and some of this PR introduces new functionality and improvements. If it's alright with you let's try and get #95727 merged first and then we can rebase some of what you've put together and continue this PR. By the way your feedback is welcome on #95727 as you're probably pretty familiar with the device. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/power/supply/gpio-charger.c?h=v6.17 |
I wasn't aware of the other PR or I would have based my work on top of that. |
Rename the bq25180 implementation and files to the more generic bq2518x. This charger family contains the bq25180, bq25186, bq25188 and the standalone (non-I2C) bq25185.
The register maps are practically identical, so the driver should be re-used.