boards: st: stm32h7s78_dk: add support for touch input #97175
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st and
mathieuchopstm
etienne-lms
reviewed
Oct 8, 2025
There was a problem hiding this comment.
Since I2C1 is now default enabled, could you add the I2C1 mapping info into thee board doc (.../doc/index.rst)?
Default Zephyr Peripheral Mapping:
----------------------------------
- USART_4 TX/RX : PD1/PD0 (VCP)
(...)
- XSPI1 NCS/DQS0/DQS1/CLK/IO: PO0/PO2/PO3/PO4/PP0..15
+- I2C1 SCL/SDA: PB6/PB9
CI build failure seems related to b1d6252:
/__w/zephyr/zephyr/samples/subsys/usb/midi/src/main.c:49:16: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
49 | .dev = midi,
| ^~~~
Comment on lines
34
to
39
| if INPUT | ||
| config INPUT_GT911_INTERRUPT | ||
| default y | ||
| endif # INPUT |
There was a problem hiding this comment.
Usually prefer with empty lines after if / before endif:
if INPUT
config INPUT_GT911_INTERRUPT
default y
endif # INPUT|
|
||
| display_ctp: gt911@5d { | ||
| compatible = "goodix,gt911"; | ||
| status = "okay"; |
There was a problem hiding this comment.
Prefer status last among the node properties:
display_ctp: gt911@5d {
compatible = "goodix,gt911";
reg = <0x5d>;
irq-gpios = <&gpioe 3 GPIO_ACTIVE_HIGH>;
status = "okay";
};| compatible = "goodix,gt911"; | ||
| status = "okay"; | ||
| reg = <0x5d>; | ||
| irq-gpios = <&gpioe 3 GPIO_ACTIVE_HIGH>; |
titouanc
force-pushed
the
stm32h7s78-touch
branch
from
ab11b53 to
d64c719
Compare
|
Thanks for your initial review @etienne-lms ! I just rebased on top of the latest main, and applied your suggestions:
|
Add support for the touch input controller on the STM32H7S78-DK: - Enable I2C1 on the board - Add device tree node for the touch controller in the display panel Signed-off-by: Titouan Christophe <[email protected]>
titouanc
force-pushed
the
stm32h7s78-touch
branch
from
d64c719 to
6ccdb97
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the touch input controller on the STM32H7S78-DK:
Tested with
samples/subsys/input/draw_touch_events