drivers: wifi: nrf_wifi: Set SSID for P2P discovery #97183
Conversation
zephyrbot
requested review from
Kludentwo,
MaochenWang1,
jukkar,
krish2718,
rlubos and
sachinthegreen
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
kapbh
force-pushed
the
p2p_find
branch
2 times, most recently
from
9ace4b9 to
13e5c91
Compare
github-actions
bot
removed
manifest
manifest-hostap
DNM (manifest)
Use `ssids` instead of `filter_ssids` to set the SSID in probe requests. `filter_ssids` are to filter scan results to include only the specified SSIDs. Signed-off-by: Ravi Dondaputi <[email protected]>
In P2P mode, inform supplicant that the driver is P2P capable. Signed-off-by: Ravi Dondaputi <[email protected]>
Add supplicant api, mgmt ops and shell command support for P2P discovery. Signed-off-by: Kapil Bhatt <[email protected]>
Update hostap revision to add wpa_cli command response with no print. Signed-off-by: Ravi Dondaputi <[email protected]> Signed-off-by: Kapil Bhatt <[email protected]>
github-actions
bot
added
manifest-hostap
DNM (manifest)
|
| params->resp[0] = '\0'; | ||
| os_strlcpy(cmd_buf, "P2P_PEER FIRST", sizeof(cmd_buf)); | ||
|
|
||
| while (1) { |
There was a problem hiding this comment.
why is this a while 1? and break only in failure?
| return -ENOEXEC; | ||
| } | ||
|
|
||
| if (resp_buf[0] != '\0') { |
There was a problem hiding this comment.
why is the response not a proper struct? Wi-Fi management should work with any network manager not just wpa_supplicant.
| return 0; | ||
| } | ||
|
|
||
| static void parse_and_print_peer_info(const struct shell *sh, const char *mac_addr, |
There was a problem hiding this comment.
move this to wpa_supplicant and only keep a proper data structure in Wi-Fi mgmt and this way you don't even need the _noprint API.
| WIFI_P2P_PEERS, | ||
| /** P2P show information about a known peer */ | ||
| WIFI_P2P_PEER, | ||
| }; |
There was a problem hiding this comment.
why two separate OPs, if known peer input is broadcast then it shows all peers, no?
6 participants
Use ssids instead of filter_ssids to set the SSID in probe requests to
DIRECT-. This is needed for identification by the P2P peers.