samples: subsys: usb: midi: fix compilation error and warnings #97204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a USB-MIDI device in a ump stream responder configuration, as obtained from the device tree with DEVICE_DT_GET(), was wrongly casting is from const struct device* to void*, hence removing the const pointer attribute. This incorrectness introduces some compilation issue. Let's therefore make the device pointer constant in ump_stream_responder_cfg, and add a macro to make the proper typecast consistently. Finally, adapt the corresponding samples to use that new macro. Signed-off-by: Titouan Christophe <[email protected]>
This fixes the following compilation warning:
format '%X' expects argument of type 'unsigned int',
but argument 2 has type 'long unsigned int'
Signed-off-by: Titouan Christophe <[email protected]>
zephyrbot
added
area: USB
zephyrbot
requested review from
JarmouniA,
jfischer-no,
jukkar,
kartben,
nashif,
pdgendt,
rlubos,
ssharks and
tmon-nordic
|
kartben
added
the
Hotfix
mbolivar
approved these changes
Oct 8, 2025
henrikbrixandersen
approved these changes
Oct 8, 2025
rlubos
approved these changes
Oct 8, 2025
|
Hi @titouanc |
|
There is #97251 that fix this warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an annoying compilation error that affects all ongoing PR since the Network MIDI 2.0 PR was merged this morning (cc @butok)