drivers:ethernet: Add promiscuous mode to the slip interface #97232
Conversation
|
Hello @mrjimenez, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
requested review from
ClaCodes,
decsny,
lmajewski,
maass-hamburg and
pdgendt
mrjimenez
force-pushed
the
promiscuos_slip
branch
from
65a6851 to
4b2702f
Compare
|
Fixed the issues with code/commit message compliance. |
drivers/ethernet/eth_slip_tap.c
Outdated
| ETH_NET_DEVICE_INIT(slip, CONFIG_SLIP_DRV_NAME, slip_init, NULL, &slip_context_data, NULL, | ||
| CONFIG_KERNEL_INIT_PRIORITY_DEFAULT, &slip_if_api, _SLIP_MTU); |
There was a problem hiding this comment.
I do not like this change, it looks like you used clang formatter which makes long lines that are just harder to read than the original code. The other format changes look ok (just place into separate commit).
There was a problem hiding this comment.
Hi Jukka,
I totally agree with you, really, I think it got much uglier. But since it is my first commit on the project, and I got a "non-conformity" error on the automated tests, I assumed all files should have passed throuhg the project's defined clang-format.
I will do as you said, split the patch and format as before.
There was a problem hiding this comment.
The CI reports clang-format issues but they are only suggestions (at least for now) and can be ignored if they do not make sense/look ugly.
This patch just formats the file before the real patch so that whitespace changes do not mix with the real code changes. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
Slip is naturally promiscuous, so this patch does nothing but acknowledge that. Promiscuous mode in slip is important to allow the interface to be added to a bridge. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
mrjimenez
force-pushed
the
promiscuos_slip
branch
from
4b2702f to
28f7cb1
Compare
|
5 participants
Slip is naturally promiscuous, so this patch does nothing but acknowledge that. Promiscuous mode in slip is important to allow the interface to be added to a bridge.