soc: nxp: imx943: Fix potential out-of-bounds access in pm_mcore loop #97239
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JiafeiPan,
Zhiqiang-Hou,
dbaluta,
dleach02,
iuliana-prodan and
yangbolu1991
1 task
JiafeiPan
reviewed
Oct 9, 2025
soc/nxp/imx/imx9/imx943/pm_mcore.c
Outdated
|
|
||
| /* IRQs enabled at NVIC level become GPC wake sources */ | ||
| for (uint32_t idx = 0; idx < nvic_iser_nb; idx++) { | ||
| for (uint32_t idx = 0; idx < GPC_CPU_CTRL_CMC_IRQ_WAKEUP_MASK_COUNT |
There was a problem hiding this comment.
Suggested change
| for (uint32_t idx = 0; idx < GPC_CPU_CTRL_CMC_IRQ_WAKEUP_MASK_COUNT | |
| for (uint32_t idx = 0; idx < MIN(GPC_CPU_CTRL_CMC_IRQ_WAKEUP_MASK_COUNT, nic_iser_nb; idx++) { |
Limit the loop to the smaller of nvic_iser_nb and GPC_CPU_CTRL_CMC_IRQ_WAKEUP_MASK_COUNT to ensure safe access. Signed-off-by: Yongxu Wang <[email protected]>
yongxu-wang15
force-pushed
the
NXP-imx943-fixed-cxx-test-build-issue
branch
from
2bdf78c to
ed626f9
Compare
|
iuliana-prodan
approved these changes
Oct 9, 2025
JiafeiPan
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the loop to the smaller of nvic_iser_nb and
GPC_CPU_CTRL_CMC_IRQ_WAKEUP_MASK_COUNT to ensure safe access.