Bluetooth: Host: Move tx_processor to new thread bt_taskq #97257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new workqueue bt_taskq specifically designed for quick non-blocking work items in the Bluetooth subsystem. This workqueue is always available and does not depend on any Kconfig option. Signed-off-by: Aleksander Wasaznik <[email protected]>
The Bluetooth Host itself performs operations on the system workqueue which are blocking waiting for the tx_processor to run. This results in deadlocks. TX processor is supposed to be non-blocking, so this change puts it on the new bt_taskq. This effectively gives tx_processor its own thread, like the BT TX thread that used to exist. But, this time this thread is intended to be shared with any other non-blocking Bluetooth Host tasks. Signed-off-by: Aleksander Wasaznik <[email protected]>
Now that tx_processor is in bt_taskq, we don't need special handling for when it runs on the syswq. Signed-off-by: Aleksander Wasaznik <[email protected]>
Reduce stack sizes for peripheral_hr sample to minimal sizes. Signed-off-by: Aleksander Wasaznik <[email protected]>
We invoked user callbacks from a net_buf_unref() inside the HCI driver.
This is not OK now that tx_processor is a non-blocking task on bt_taskq.
Instead defer the net_buf destruction to the system workqueue.
This was detected because the following test was failing:
tests/bsim/bluetooth/ll/throughput/tests_scripts/gatt_write.sh
Signed-off-by: Aleksander Wasaznik <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.