Fix enterprise mode external certs #97268
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to set the test certificates directory for enterprise mode when an external certs directory is provided at build time. This change overrides the default certs folder if a different path is specified during build. Signed-off-by: Triveni Danda <[email protected]>
Increased wpa_supplicant heap size for enterprise mode to support larger certificates required during connection. This is needed in case if any larger certs are passed than default certs. Signed-off-by: Triveni Danda <[email protected]>
|
krish2718
reviewed
Oct 9, 2025
| set(gen_inc_dir ${ZEPHYR_BINARY_DIR}/misc/generated) | ||
| set(gen_dir ${gen_inc_dir}/wifi_enterprise_test_certs) | ||
| zephyr_get(WIFI_TEST_CERTS_DIR SYSBUILD GLOBAL) | ||
| message("WIFI_TEST_CERTS_DIR is set to ${WIFI_TEST_CERTS_DIR}") |
There was a problem hiding this comment.
the override is already supported https://docs.zephyrproject.org/latest/connectivity/networking/api/wifi.html#wi-fi-enterprise-test-x-509-certificate-management DWIFI_TEST_CERTS_DIR=<>, why is this needed? Is it only for sysbuild?
krish2718
reviewed
Oct 9, 2025
| def_int 60000 if WIFI_USAGE_MODE_STA_AP | ||
| def_int 55000 if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE && WIFI_CREDENTIALS | ||
| def_int 48000 if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE | ||
| def_int 55000 if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE |
There was a problem hiding this comment.
To avoid generic increase, document this and let user configure higher heap? This affects all cases including smaller certs. And also we should define large certs e.g., chained CAs ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to set the test certificates directory for enterprise mode when an external certs directory is provided at build time.