drivers: disk: sdmmc_stm32: HAL return value handling #97277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
danieldegrasse,
decsny,
djiatsaf-st,
erwango,
gautierg-st,
jfischer-no,
marwaiehm-st and
mathieuchopstm
etienne-lms
force-pushed
the
stm32-hal-ret-sdmmc
branch
from
4c0387a to
e49a091
Compare
Ensure STM32 SDMMC driver returns proper errno values and not HAL return codes. Signed-off-by: Etienne Carriere <[email protected]>
Clarify HAL return value is of type HAL_StatusTypeDef and may not be a int. This change aims preventing one from mixing standard "errno" int return values and STM32 HAL return value finding misleading implementation in existing code. No functional change. Signed-off-by: Etienne Carriere <[email protected]>
Add tests of the value returned by initialization and deinitialization HAL functions. Signed-off-by: Etienne Carriere <[email protected]>
etienne-lms
force-pushed
the
stm32-hal-ret-sdmmc
branch
from
e49a091 to
ddaa0c3
Compare
|
Rebased since #94895 has been merged (adds an occurrence to address). |
|
erwango
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify HAL return value is of type
HAL_StatusTypeDefand may not be aint.This change aims preventing one from mixing standard "errno"intreturn values and STM32 HAL return value finding misleading implementation in existing code.Add tests of the value returned by initialization and deinitialization HAL functions.