drivers: display: stm32: HAL return value handling #97278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
danieldegrasse,
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
JarmouniA,
jfischer-no,
marwaiehm-st,
mathieuchopstm and
VynDragon
drivers/display/display_stm32_ltdc.c
Outdated
| { | ||
| int err; | ||
| struct display_stm32_ltdc_data *data = dev->data; | ||
| HAL_StatusTypeDeft err; |
There was a problem hiding this comment.
Suggested change
| HAL_StatusTypeDeft err; | |
| HAL_StatusTypeDef err; |
?
Correct stm32_ltdc_set_pixel_format() to return a valid errno instead of mixing HAL return values and errno return values. Signed-off-by: Etienne Carriere <[email protected]>
etienne-lms
force-pushed
the
stm32-hal-ret-display
branch
from
36fe11f to
1f9f758
Compare
Correct mipi_dsi_stm32_host_init() and mipi_dsi_stm32_attach() to return a valid errno instead of mixing HAL return values and errno return values. Clarify HAL return value is of type HAL_StatusTypeDef and not an int in mipi_dsi_stm32_transfer(). Signed-off-by: Etienne Carriere <[email protected]>
etienne-lms
force-pushed
the
stm32-hal-ret-display
branch
from
1f9f758 to
5c82f71
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct
stm32_ltdc_set_pixel_format()to return a valid errno instead of mixing HAL return values and errno return values.Correct
mipi_dsi_stm32_host_init()andmipi_dsi_stm32_attach()to return a valid errno instead of mixing HAL return values and errno return values.Clarify HAL return value is of type
HAL_StatusTypeDefand not anintinmipi_dsi_stm32_transfer().