riscv: pmp: Consolidate PMP entry writes in z_riscv_pmp_init #97315
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
npitre,
tgorochowik and
ycsin
fsammoura1980
force-pushed
the
consolidate_writes
branch
3 times, most recently
from
134fee0 to
97c6a63
Compare
Removes redundant calls to write_pmp_entries() from within conditional compilation blocks (CONFIG_PMP_STACK_GUARD, CONFIG_MULTITHREADING). This change consolidates the logic to write the configured PMP entries into a single call at the end of the z_riscv_pmp_init() function. This simplifies the code, reduces redundancy, and ensures the PMP registers are updated once after all potential entries have been configured. Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
consolidate_writes
branch
from
97c6a63 to
5197924
Compare
|
This PR will pass CQ once this PR is merged |
|
|
As #97314 (comment), this is needed to ensure kernel initialization doesn't violate the PMP configuration, including ROM protection, null pointer, and stack guard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes redundant calls to write_pmp_entries() from within conditional compilation blocks (CONFIG_PMP_STACK_GUARD, CONFIG_MULTITHREADING).
This change consolidates the logic to write the configured PMP entries into a single call at the end of the z_riscv_pmp_init() function. This simplifies the code, reduces redundancy, and ensures the PMP registers are updated once after all potential entries have been configured.