Skip to content

Conversation

@tbursztyka
Copy link
Contributor

@tbursztyka tbursztyka commented Oct 10, 2025

Found some time so re-posting the previously merged then reverted PR #90014

  • SOF issue fixed (@lyakh : it seems to build fine now)
  • made a better patch on check_init_priorities.py so now it looks up for the init function in the object, whether it is a device or a service.

Beside that, no changes.

@tbursztyka
Copy link
Contributor Author

Don't know why code guidelines points out issues that are not from my patches, but anyway: added one to make it happy.

@lyakh
Copy link
Contributor

lyakh commented Oct 13, 2025

SOF issue fixed (@lyakh : it seems to build fine now)

Thanks for fixing! I haven't checked, but with your verification and if nobody else complains that their build is broken, I think chances are good that this will work indeed.

Since the addition of deinit operation in device, init and deinit have
been within each device, rendering their init entry's init function
useless.

In order to save ROM space, let's remove the init function from
init entry altogether, and introduce a new object called "service"
which owns an init function to go along with SYS_INIT/SYS_INIT_NAMED.

Signed-off-by: Tomasz Bursztyka <[email protected]>
As the pointer has been removed from struct init_entry, it should be
looked up in the pointed object instead, as it has been done already
for device objects.

Signed-off-by: Tomasz Bursztyka <[email protected]>
Following the changes on struct init_entry

Signed-off-by: Tomasz Bursztyka <[email protected]>
struct init_entry may point to a struct device or a struct service,
each ones belonging to device or service iterable section.
Service section being newly added, handling it in cmake relevantly.

Signed-off-by: Tomasz Bursztyka <[email protected]>
To make CI happier.

Signed-off-by: Tomasz Bursztyka <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants