modem: cmux: Define macros for header size #97333
Merged
+23
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppoTakalo
requested review from
JordanYates,
bjarki-andreasen and
rerickson1
SeppoTakalo
force-pushed
the
cmux_macros
branch
from
23fcd2c to
f888cbf
Compare
|
Just realized that after #96897 the header size is also referenced in the header, so I moved the macros to header. So CMUX length value in frame is only 1 byte as long as MTU is less or equal to 127. Then total size of header is 6 bytes, not 7 as assumed. |
SeppoTakalo
force-pushed
the
cmux_macros
branch
from
f888cbf to
1d7701b
Compare
tomi-font
approved these changes
Oct 10, 2025
Define CMUX_HEADER_SIZE macro that is 6 or 7 bytes depending on MTU. Remove the previous CMUX_FRAME_SIZE_MAX that was a bit misleading as it meant only the header size without data and was fixed to 7 bytes. Redefine new macros CMUX_FRAME_SIZE_MAX and CMUX_FRAME_SIZE_MIN which are actually frame sizes with data included. Signed-off-by: Seppo Takalo <[email protected]>
SeppoTakalo
force-pushed
the
cmux_macros
branch
from
1d7701b to
d64d001
Compare
|
Fixed the wording in commit message as suggested by Tomi. |
|
rerickson1
approved these changes
Oct 10, 2025
bjarki-andreasen
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define CMUX_HEADER_SIZE macro that is 6 or 7 bytes depending on
MTU.
Remove the previous CMUX_FRAME_SIZE_MAX that was a bit misleading
as it meant only the header size without data and was fixed to 7 bytes.
Redefine new macros CMUX_FRAME_SIZE_MAX and CMUX_FRAME_SIZE_MIN which
are actually frame sizes with data included.