-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Bugfix/harunspago/55186 fnmatch known bug #97400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bugfix/harunspago/55186 fnmatch known bug #97400
Conversation
Hello @Spago123, and thank you very much for your first pull request to the Zephyr project! |
@Spago123 - really nice, thanks! Just a couple of housekeeping requests. I like that you've broken this up into separate commits, but can the commits be redone in this order:
Please make sure the commit messages are really clear about what is being done and why in each commit. |
fb271dc
to
dd6ce78
Compare
Yup I reorderd and split the needed commit as you suggested |
0883837
to
9cd4353
Compare
@Spago123 - some CI errors related to |
Yup it seems there is an issue with those fucntions on some platforms, I added custom implementations that satistify the library definitions |
6625e76
to
285079e
Compare
Implemented match_posix_class function that was needed to match the possible posix classes like alnum, alpha etc... Signed-off-by: Harun Spago <[email protected]>
Added tests for isprint, ispunct, islower and other posix classes Signed-off-by: Harun Spago <[email protected]>
Some Ifs had the same condition so insted of duplicating that work simple helper functions have been created Signed-off-by: Harun Spago <[email protected]>
Added Doxygen on new functions and on fnmatch function Signed-off-by: Harun Spago <[email protected]>
Resolved all sonar qube issues Signed-off-by: Harun Spago <[email protected]>
Added custom implementations for islower and ispunch since there is some issue with compilenace on some platforms Signed-off-by: Harun Spago <[email protected]>
Formated fnmatch c and h files and test files using clang-format Signed-off-by: Harun Spago <[email protected]>
285079e
to
6c3a529
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Fixed failling tests in fnmatch.c test file.
Removed duplicated code and added simplicfications.
Added new test cases.
Stepts to test run:
west build -p -b qemu_cortex_a53 -t run tests/posix/c_lib_ext/
in the shell and you shall get the next result:
- PASS - [posix_c_lib_ext.test_fnmatch] duration = 0.001 seconds
Fixes #55186