-
Notifications
You must be signed in to change notification settings - Fork 8.1k
boards: st: n6_dk: fix active state for cd gpio #97412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @SetZero, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SetZero for this fix.
Could you fix the commit message? 74 char/line max for the message for commit message + add your Signed-off-by tag.
Otherwise LGTM.
@etienne-lms Thanks for the feedback. It should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good. Could you replace Sebastian
in the commit author and Signed-off-by tag with a full name, as per DCO guidelines?
Signed-off-by: Your Name <[email protected]>
For your commits, replace:
- Your Name with your legal name (pseudonyms, hacker handles, and the names of groups are not allowed)
- ...
Also, a minor think: for (a bit more) consistency of the commits modifying this board directory, could you change in the commit message header line? E.g.:
-boards: st: n6_dk: fix active state for cd gpio
+boards: st: stm32n6570_dk: fix active state for cd gpio
should be fixed now
sounds good, I've changed it |
@SetZero, there is a typo in the e-mail address of the patch author. Check your ~/.gitconfig file or like: |
CD pin of the SDMMC on the STM32N6570-DK board was incorrectly set as active high, but is actually active low Signed-off-by: Sebastian Dauenhauer <[email protected]>
|
Hi @SetZero! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
BTW @etienne-lms Thanks for your help and patience 👍 |
With pleasure. Thanks for your contribution. |
CD pin of the SDMMC on the STM32N6570-DK board was incorrectly set as active high, but is actually active low:
