Skip to content

Conversation

SetZero
Copy link
Contributor

@SetZero SetZero commented Oct 12, 2025

CD pin of the SDMMC on the STM32N6570-DK board was incorrectly set as active high, but is actually active low:
image

Copy link

Hello @SetZero, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SetZero for this fix.
Could you fix the commit message? 74 char/line max for the message for commit message + add your Signed-off-by tag.

Otherwise LGTM.

@SetZero
Copy link
Contributor Author

SetZero commented Oct 13, 2025

@etienne-lms Thanks for the feedback. It should be fixed now

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good. Could you replace Sebastian in the commit author and Signed-off-by tag with a full name, as per DCO guidelines?

Signed-off-by: Your Name <[email protected]>
For your commits, replace:

  • Your Name with your legal name (pseudonyms, hacker handles, and the names of groups are not allowed)
  • ...

Also, a minor think: for (a bit more) consistency of the commits modifying this board directory, could you change in the commit message header line? E.g.:

-boards: st: n6_dk: fix active state for cd gpio
+boards: st: stm32n6570_dk: fix active state for cd gpio

@SetZero
Copy link
Contributor Author

SetZero commented Oct 13, 2025

Almost good. Could you replace Sebastian in the commit author and Signed-off-by tag with a full name, as per DCO guidelines?

should be fixed now

Also, a minor think: for (a bit more) consistency of the commits modifying this board directory, could you change in the commit message header line? E.g.:

sounds good, I've changed it

@etienne-lms
Copy link
Contributor

@SetZero, there is a typo in the e-mail address of the patch author. Check your ~/.gitconfig file or like:
@magial.rocks vs @magical.rocks

CD pin of the SDMMC on the STM32N6570-DK board was incorrectly set as
active high, but is actually active low

Signed-off-by: Sebastian Dauenhauer <[email protected]>
Copy link

@erwango erwango requested a review from etienne-lms October 15, 2025 08:53
@erwango erwango added this to the v4.3.0 milestone Oct 15, 2025
@jhedberg jhedberg merged commit 3c64864 into zephyrproject-rtos:main Oct 15, 2025
26 checks passed
Copy link

Hi @SetZero!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@SetZero
Copy link
Contributor Author

SetZero commented Oct 15, 2025

BTW @etienne-lms Thanks for your help and patience 👍

@SetZero SetZero deleted the patch-1 branch October 15, 2025 09:34
@etienne-lms
Copy link
Contributor

With pleasure. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants