tests: c_lib: common: remove test_time_t #97415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `time_t` was only checked in some C libraries to be greater than or equal to a 64-bit integer and it was skipped in other C libraries. The C standard still does not make this guarantee, and other code within Zephyr already has been changed to accomodate both 32-bit `time_t` and 64-bit `time_t`. There really is no point in having this test, since it is inconsistent at best. Until Zephyr changes to a 64-bit `time_t` (e.g. `time64_t`), then there is no guarantee of safety against the Y2038 problem. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
remove-libc-common-time-t-check
branch
2 times, most recently
from
0e0f8e3 to
983e934
Compare
zephyrbot
added
area: Tests
zephyrbot
requested review from
aescolar,
keith-packard,
nashif and
stephanosio
|
stephanosio
approved these changes
Oct 13, 2025
aescolar
approved these changes
Oct 13, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
time_twas only checked in some C libraries to be greater than or equal to a 64-bit integer and it was skipped in other C libraries.The C standard still does not make this guarantee, and other code within Zephyr already has been changed to accomodate both 32-bit
time_tand 64-bittime_t.There really is no point in having this test, since it is inconsistent at best.
Until Zephyr changes to a 64-bit
time_t(e.g.time64_t), then there is no guarantee of safety against the Y2038 problem.