-
Notifications
You must be signed in to change notification settings - Fork 8k
shell: openthread/shell/boards folder creation to support MCXW7x #97532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Creation of the zephyr/samples/net/openthread/shell/boards to support the MCXW7x boards components. Signed-off-by: Xavier Razavet <[email protected]>
|
# | ||
# Copyright (c) 2025 Project CHIP Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use SPDX identifier instead (# SPDX-License-Identifier: Apache-2.0
)
:conf: "prj-ot-host-nxp.conf" | ||
:goals: build | ||
:compact: | ||
west build -b frdm_rw612 zephyr/samples/net/openthread/shell -d <build_path> -p -- -DEXTRA_CONF_FILE="prj-ot-host-nxp.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add the comment explicitly, the sole purpose of the above snippet is to generate the command in the documentation.
:conf: "prj-ot-host-nxp.conf" | ||
:goals: build | ||
:compact: | ||
west build -b frdm_mcxw72/mcxw727c/cpu0 zephyr/samples/net/openthread/shell -d <build_path> -p -- -DEXTRA_CONF_FILE="prj-ot-host-nxp.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
extra_args: | ||
# Disabling monolithic since CI environment doesn't use blobs | ||
- CONFIG_NXP_MONOLITHIC_NBU=n | ||
- EXTRA_CONF_FILE="overlay-ot-rcp-host-nxp.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the overlay really no longer needed? It seems to configure way more compared to what's added in this PR.
extra_args: | ||
- CONFIG_BUILD_ONLY_NO_BLOBS=y | ||
# Disabling monolithic since CI environment doesn't use blobs | ||
- CONFIG_NXP_MONOLITHIC_NBU=n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variant sample.net.openthread.shell.esp seems to have been added to cover ESP boards specifically, please don't modify their confguration with NXP-specific stuff. Please add a new build variant, or cosider unifying with rw612_openthread_rcp_host
if possible.
Creation of the zephyr/samples/net/openthread/shell/boards to support the MCXW7x boards components.