-
Notifications
You must be signed in to change notification settings - Fork 8.1k
riscv: use riscv,isa-extensions dt prop #97540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
riscv: use riscv,isa-extensions dt prop #97540
Conversation
add dt_node_array_prop_has_val function and extend dt_nodelabel_array_prop_has_val to be used with string-arrays. Signed-off-by: Fin Maaß <[email protected]>
implement and use riscv,isa-extensions dt prop, like in linux https://www.kernel.org/doc/Documentation/devicetree/bindings/riscv/extensions.yaml to set the riscv extentions. Signed-off-by: Fin Maaß <[email protected]>
make riscv,isa dt prop no longer required, as it is is not really used by anyrhing in zephyr and we now have a alternative (riscv,isa-base and riscv,isa-extensions). Signed-off-by: Fin Maaß <[email protected]>
use riscv,isa-extensions dt prop for litex vexriscv soc. Signed-off-by: Fin Maaß <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good stuff, but I'd love to see this applied to the rest of RISC-V SoCs in Zephyr.
- riscv,sv48 | ||
- riscv,none | ||
|
||
riscv,isa: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the riscv,isa
property then? Since it's made redundant with riscv,isa-base
and riscv,isa-extensions
?
required: true | ||
type: string | ||
|
||
riscv,isa-base: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both riscv,isa-base
and riscv-isa-extensions
should probably be marked as required
IMO
@fkokosinski |
some soc like SOC_IT8XXX2 currently have different values in the dts and the Kconfig, therefore I would like to migrate such socs in it's own PR. |
Not sure - right now we're leaving the |
I would assume if any switching is to be done, making it required avoids missing some socs, so probably for the next cycle |
okay, then next cycle. For this to work for f and d extension, #97981 should be merged before, maybe we could get that in this cycle. |
implement and use riscv,isa-extensions
dt prop, like in linux
https://www.kernel.org/doc/Documentation/devicetree/bindings/riscv/extensions.yaml
to set the riscv extensions.
Usefull for softcores like vexriscv or vexiiriscv, that can be easily configured to add these extentions and we don't want to create a separate soc for every possible combination.
For now just just applying it to the litex_vexriscv soc, applying it for the whole tree will be part of a separate PR.