Skip to content

Conversation

jvermillard
Copy link
Contributor

@jvermillard jvermillard commented Oct 14, 2025

Introduce lwm2m_set_cache_filter() so applications can drop cached samples before they reach the LwM2M SEND path.

Fixes #91590

@zephyrbot zephyrbot added area: LWM2M area: Networking area: Tests Issues related to a particular existing or missing test labels Oct 14, 2025
@jvermillard jvermillard force-pushed the filter-lwm2m-cache branch 2 times, most recently from 7e581a8 to 82f43d8 Compare October 14, 2025 13:18
rlubos
rlubos previously approved these changes Oct 14, 2025
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jukkar
jukkar previously approved these changes Oct 14, 2025
Comment on lines 1659 to 1660
LOG_ERR("LwM2M resource cache is only supported for "
"CONFIG_LWM2M_RESOURCE_DATA_CACHE_SUPPORT");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOG_ERR("LwM2M resource cache is only supported for "
"CONFIG_LWM2M_RESOURCE_DATA_CACHE_SUPPORT");

The LOG_ERR is a bit pointless here. I would suggest to drop it as those WRN, and ERR level are the last one to be left out so even without enabling the cache, this string would stay in the flash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it

SeppoTakalo
SeppoTakalo previously approved these changes Oct 14, 2025
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Introduce `lwm2m_set_cache_filter()` so applications can drop cached
samples before they reach the LwM2M SEND path.

Fixes zephyrproject-rtos#91590

Signed-off-by: Julien Vermillard <[email protected]>
@jvermillard jvermillard dismissed stale reviews from SeppoTakalo, rlubos, and jukkar via 78f94f5 October 14, 2025 14:40
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: LWM2M area: Networking area: Tests Issues related to a particular existing or missing test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWM2M: send arbitrary data

5 participants