-
Notifications
You must be signed in to change notification settings - Fork 8.1k
net: lwm2m: add cache filtering #97545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
net: lwm2m: add cache filtering #97545
Conversation
7e581a8
to
82f43d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LOG_ERR("LwM2M resource cache is only supported for " | ||
"CONFIG_LWM2M_RESOURCE_DATA_CACHE_SUPPORT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG_ERR("LwM2M resource cache is only supported for " | |
"CONFIG_LWM2M_RESOURCE_DATA_CACHE_SUPPORT"); |
The LOG_ERR
is a bit pointless here. I would suggest to drop it as those WRN, and ERR level are the last one to be left out so even without enabling the cache, this string would stay in the flash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
82f43d8
to
9e7f614
Compare
Introduce `lwm2m_set_cache_filter()` so applications can drop cached samples before they reach the LwM2M SEND path. Fixes zephyrproject-rtos#91590 Signed-off-by: Julien Vermillard <[email protected]>
78f94f5
9e7f614
to
78f94f5
Compare
|
Introduce
lwm2m_set_cache_filter()
so applications can drop cached samples before they reach the LwM2M SEND path.Fixes #91590