Update snvs rtc for generic rtc driver and enable it for RT10xx boards #97551

Holt-Sun · 2025-10-14T14:16:54Z

Update snvs rtc for generic rtc driver.
Enable it for RT10xx boards: samples and tests.

decsny · 2025-10-14T17:08:45Z

drivers/counter/counter_mcux_snvs.c

+	SNVS_HP_RTC_EnableInterrupts(config->base, kSNVS_RTC_AlarmInterrupt);
+#ifdef MCUX_SNVS_SRTC
+	SNVS_LP_SRTC_EnableInterrupts(config->base, kSNVS_SRTC_AlarmInterrupt);
+#endif


nit: you could #define SNVS_ALARM_INERRUPT or something to the right value in one place instead of repeating this #ifdef MCUX_SNVS_SRTC in multiple places of the file.

Updated: add SRTC helper macros.

decsny · 2025-10-14T17:11:41Z

drivers/counter/counter_mcux_snvs.c

+			cb = data->alarm_hp_rtc_callback;
+			data->alarm_hp_rtc_callback = NULL;


I think I don't have the context, but why are you setting the stored callback pointer to null?

Counter API semantics (counter.h) say alarms are single-shot: “After expiration … channel is considered available and can be set again.” Drivers must clear their “alarm active” state so counter_set_channel_alarm can succeed again. Calling mcux_snvs_cancel_alarm() inside the ISR is not ideal (it busy-waits on HPCR/LPCR bits). Nulling the stored callback is the more common way, many Zephyr drivers do this way(e.g., mcux_rtc.c, mcux_lpc_rtc.c, mcux_gpt.c, mcux_ctimer.c).

decsny · 2025-10-14T17:11:52Z

drivers/counter/counter_mcux_snvs.c

-			mcux_snvs_cancel_alarm(dev, 0);
+			cb = data->alarm_hp_rtc_callback;
+			data->alarm_hp_rtc_callback = NULL;
+			cb(dev, 0, current, data->alarm_hp_rtc_user_data);


check for null pointer first?

decsny · 2025-10-14T17:12:21Z

boards/nxp/mimxrt1064_evk/mimxrt1064_evk.dts

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, NXP
+ * Copyright (c) 2018,2025 NXP


remove (c) and put a space after the comma.

decsny · 2025-10-14T17:12:43Z

dts/arm/nxp/nxp_rt10xx.dtsi

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017,2023,2024 NXP
+ * Copyright 2017,2023,2024,2025 NXP


put spaces after commas

Updated to "2017, 2023-2025".

decsny · 2025-10-14T17:13:23Z

boards/nxp/mimxrt1064_evk/mimxrt1064_evk.dts

 dvp_fpc24_interface: &csi {};
+
+&snvs_rtc {
+	status = "okay";


this one looks redundant, it looks not disabled in the soc dtsi

decsny · 2025-10-14T17:14:50Z

samples/drivers/rtc/boards/mimxrt1064_evk.conf

+#
+# Copyright 2025 NXP
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+
+CONFIG_RTC_ALARM=y
+CONFIG_RTC_INIT_PRIORITY=70


IMO squash overlay to previous (board) commit, we dont want to bloat the commit log with habit of putting an overlay for a test of a feature in another commit as where the feature is added, this is really not necessary, it's a routine basic part of enabling the feature on a board

I have enabled all RT10xx boards, so I reorganize the commits. Please review again.

decsny · 2025-10-14T17:17:23Z

tests/drivers/rtc/rtc_api/boards/mimxrt1064_evk.conf

+#
+# Copyright 2025 NXP
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+
+CONFIG_RTC_ALARM=y
+CONFIG_RTC_INIT_PRIORITY=70
+CONFIG_TEST_RTC_ALARM_TIME_MASK=255


two commits each for an overlay, squash to the board commit. there should only be 2 commits on this PR, not 4. We don't need a commit for every file added, that is too much. A commit is for a reviewable and isolatable and complete unit of work. These tiny overlay is part of the work of enabling the feature on the board.

I have enabled all RT10xx boards, so I reorganize the commits. Please review again.

bjarki-andreasen

The board using the "virtual" RTC to the rtc api test suite must be redundant, it should work with any counter, and should be tested using FFF. If the counter test suites pass, the RTC API test will also pass if the rtc_counter has been tested well enough.

decsny · 2025-10-15T12:49:41Z

@Holt-Sun since the test overlay are all the same, i would look to make a testcase in the .yaml instead, I think bjarki is blocking because all the overlay can get annoying

Holt-Sun · 2025-10-15T14:15:34Z

The board using the "virtual" RTC to the rtc api test suite must be redundant, it should work with any counter, and should be tested using FFF. If the counter test suites pass, the RTC API test will also pass if the rtc_counter has been tested well enough.

Not exactly, the rtc_counter APIs have limitation, like it cannot support frequency not equal 1. When I enable a new platform, the counter test cases all run passed but RTC test cases run failed.
As suggested by @decsny , I add a new test case and deprecate the conf in rtc test folder. Now it is more clear. Please review.

Holt-Sun · 2025-10-15T14:17:24Z

@Holt-Sun since the test overlay are all the same, i would look to make a testcase in the .yaml instead, I think bjarki is blocking because all the overlay can get annoying

Good suggestion, updated.

bjarki-andreasen

ok, I like this better, though still not a fan of testing a purely software feature with real hardware, better than not testing it, but it makes it hard to see if an issue is with the hardware or rtc counter wrapper if something fails

EmilioCBen · 2025-10-15T18:02:29Z

@Holt-Sun Please add
- rtc
to the board.yaml files or twister will not pick up on the tests for running.

EmilioCBen

Blocking on adding the rtc to the board.yaml as mentioned above.

1. Add SRTC helper macros. 2. Implement start/stop APIs. Signed-off-by: Holt Sun <[email protected]>

The counter_rtc child node is for rtc-counter. Signed-off-by: Holt Sun <[email protected]>

enable SNVS counter_rtc for mimxrt10xx board. Signed-off-by: Holt Sun <[email protected]>

Add "rtc" into supported board.yaml. Signed-off-by: Holt Sun <[email protected]>

enable alarm and init priority for mimxrt10xx sample/drivers/rtc Signed-off-by: Holt Sun <[email protected]>

add drivers.rtc.rtc_api.rtc_counter test case for counter rtc. Signed-off-by: Holt Sun <[email protected]>

sonarqubecloud · 2025-10-16T06:52:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Samples Samples platform: NXP NXP area: Tests Issues related to a particular existing or missing test area: Boards/SoCs platform: NXP MCU area: Counter area: RTC Real Time Clock labels Oct 14, 2025

zephyrbot requested review from DerekSnell, EmilioCBen, JarmouniA, bjarki-andreasen, butok, dbaluta, decsny, dleach02, kartben, manuargue, mmahadevan108, nashif and nordic-krch October 14, 2025 14:18

zephyrbot assigned bjarki-andreasen Oct 14, 2025

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 0cac71e to b033e53 Compare October 14, 2025 14:24

EmilioCBen previously approved these changes Oct 14, 2025

View reviewed changes

decsny requested changes Oct 14, 2025

View reviewed changes

Holt-Sun dismissed EmilioCBen’s stale review via 089bd2d October 15, 2025 10:08

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from b033e53 to 089bd2d Compare October 15, 2025 10:08

Holt-Sun changed the title ~~Update mimxrt1064 snvs rtc for generic rtc driver~~ Update snvs rtc for generic rtc driver and enable it for RT10xx boards Oct 15, 2025

Holt-Sun requested review from EmilioCBen and decsny October 15, 2025 10:12

bjarki-andreasen requested changes Oct 15, 2025

View reviewed changes

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 089bd2d to 9029b4a Compare October 15, 2025 14:07

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 9029b4a to 0873a20 Compare October 15, 2025 14:35

bjarki-andreasen previously approved these changes Oct 15, 2025

View reviewed changes

decsny previously approved these changes Oct 15, 2025

View reviewed changes

EmilioCBen requested changes Oct 15, 2025

View reviewed changes

Holt-Sun added 5 commits October 16, 2025 12:50

drivers: counter: mcux_snvs: update driver codes.

fd7a149

1. Add SRTC helper macros. 2. Implement start/stop APIs. Signed-off-by: Holt Sun <[email protected]>

dts: nxp: rt10xx: add zephyr,rtc-counter child under SNVS

22d2e60

The counter_rtc child node is for rtc-counter. Signed-off-by: Holt Sun <[email protected]>

boards: nxp: mimxrt10xx: enable SNVS counter_rtc

6374e44

enable SNVS counter_rtc for mimxrt10xx board. Signed-off-by: Holt Sun <[email protected]>

boards: nxp: add rtc into supported board.

35e2513

Add "rtc" into supported board.yaml. Signed-off-by: Holt Sun <[email protected]>

samples: drivers: rtc: add mimxrt10xx board configs

3d44313

enable alarm and init priority for mimxrt10xx sample/drivers/rtc Signed-off-by: Holt Sun <[email protected]>

Holt-Sun dismissed stale reviews from decsny and bjarki-andreasen via 649e73c October 16, 2025 04:51

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 0873a20 to 649e73c Compare October 16, 2025 04:51

zephyrbot requested a review from MaochenWang1 October 16, 2025 04:53

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 649e73c to 8ca451e Compare October 16, 2025 05:38

zephyrbot requested a review from bjarki-andreasen October 16, 2025 05:39

tests: drivers: rtc: rtc_api: add new test case.

20f6af6

add drivers.rtc.rtc_api.rtc_counter test case for counter rtc. Signed-off-by: Holt Sun <[email protected]>

Holt-Sun force-pushed the update-rt1064-snvs-rtc-for-generic-rtc-driver branch from 8ca451e to 20f6af6 Compare October 16, 2025 06:34

Holt-Sun requested review from EmilioCBen and decsny October 16, 2025 07:42

bjarki-andreasen approved these changes Oct 16, 2025

View reviewed changes

EmilioCBen approved these changes Oct 16, 2025

View reviewed changes

cfriedt merged commit 69cdf19 into zephyrproject-rtos:main Oct 16, 2025
43 checks passed

		cb = data->alarm_hp_rtc_callback;
		data->alarm_hp_rtc_callback = NULL;

Update snvs rtc for generic rtc driver and enable it for RT10xx boards #97551

Update snvs rtc for generic rtc driver and enable it for RT10xx boards #97551

Uh oh!

Conversation

Holt-Sun commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjarki-andreasen left a comment

Choose a reason for hiding this comment

Uh oh!

decsny commented Oct 15, 2025

Uh oh!

Holt-Sun commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Holt-Sun commented Oct 15, 2025

Uh oh!

bjarki-andreasen left a comment

Choose a reason for hiding this comment

Uh oh!

EmilioCBen commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmilioCBen left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 16, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Holt-Sun commented Oct 14, 2025 •

edited

Loading

Holt-Sun commented Oct 15, 2025 •

edited

Loading

EmilioCBen commented Oct 15, 2025 •

edited

Loading