riscv: pmp: Factor out PMP address reading logic #97574
Merged
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
npitre,
tgorochowik and
ycsin
jimmyzhe
reviewed
Oct 15, 2025
fsammoura1980
force-pushed
the
read_addr_pmp
branch
from
686f7d3 to
1c83801
Compare
jimmyzhe
previously approved these changes
Oct 15, 2025
|
LGTM, but you'd have to rebase your branch to resolve conflicts reported by GitHub. |
Refactor the code to read all PMP address CSRs (pmpaddr0 through pmpaddrN) into a new helper function, `z_riscv_pmp_read_addr`. This change encapsulates the register reading loop, improving code organization and potential reusability. The new function includes size assertions Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
read_addr_pmp
branch
from
1c83801 to
139f0c8
Compare
I rebased and resolved conflicts. |
|
jimmyzhe
approved these changes
Oct 20, 2025
fkokosinski
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code to read all PMP address CSRs (pmpaddr0 through pmpaddrN) into a new helper function,
z_riscv_pmp_read_addr.This change encapsulates the register reading loop, improving code organization and potential reusability. The new function includes size assertions