dts: bindings: sensor: ti,ina226: Added missing enum #97588
Conversation
zephyrbot
added
size: XS
zephyrbot
requested review from
MaureenHelm,
asemjonovs,
avisconti,
jeppenodgaard,
teburd,
tristan-google,
ubieda,
vaishnavachath and
yperess
- Removal of double enum (by me) caused wrong later enum entries - See commit 36abe5e - Added the second power down state (but with different name) -> This restores the old function but still fixes the double enum issue Signed-off-by: Martin Koehler <[email protected]>
metratec-mkoehler
force-pushed
the
ti_ina_226_opmode_enum_fix
branch
from
c455187 to
45fa1bf
Compare
The documentation of INA226 has both labeled the same. They are distinct in the value that's in the register but as far as I can see they are functional identical. Thanks for the feedback. I looked a bit into the enum and bindings and if I see this right I have to either change to an int type with description of the possible values and their meaning OR have to map the string entries to the correct mode values in driver, right? Or keep the work around like it is now. For my taste loosing the string values is not nice and would also break currently existing code using the driver. |
- as the pull request is just running I can also properly indent Signed-off-by: Martin Koehler <[email protected]>
|
4 participants
-> This restores the old function but still fixes the double enum issue