Bluetooth: Host: deprecate CONFIG_BT_FIXED_PASSKEY #97597

HaavardRei · 2025-10-15T09:33:07Z

Deprecates the CONFIG_BT_FIXED_PASSKEY config and adds CONFIG_BT_APP_PASSKEY as an alternative.

Updates the bt shell implementation to use the new config option.

m-alperen-sener

Looks good small comments and suggestion.
Should we update the API documentation for bt_passkey_set() in conn.h ?

doc/releases/migration-guide-4.3.rst

subsys/bluetooth/host/Kconfig

subsys/bluetooth/host/smp.c

subsys/bluetooth/host/Kconfig

PavelVPV

LGTM, 2 minor comments.

Also, it would probably be good to have some simple multilink bsim test to check parallel pairing, but this is up to you. We can do this separately later as well.

subsys/bluetooth/host/smp.c

m-alperen-sener · 2025-10-20T12:28:19Z

include/zephyr/bluetooth/conn.h

+	 *
+	 *  If implemented, this callback allows the application to provide passkeys for pairing.
+	 *  The valid range of passkeys is 0 - 999999, and should be expected to be zero-padded to
+	 *  6 digits. The application shall return the passkey for pairing, or BT_PASSKEY_RAND to


Suggested change

* 6 digits. The application shall return the passkey for pairing, or BT_PASSKEY_RAND to

* The valid range of passkeys is 0 - 999999. The application shall return the passkey for pairing, or BT_PASSKEY_RAND to

callback just returns uint32_t. Passkey is zero-padded on display only I guess.

m-alperen-sener · 2025-10-20T12:57:36Z

doc/releases/migration-guide-4.3.rst

+* :kconfig:option:`CONFIG_BT_FIXED_PASSKEY` has been deprecated. Instead, the application can
+  provide passkeys for pairing using the :c:member:`bt_conn_auth_cb.app_passkey` callback, which is
+  available when :kconfig:option:`CONFIG_BT_APP_PASSKEY` is enabled. The application can return the
+  passkey for pairing, or :c:macro:`BT_PASSKEY_RAND` to generate a random passkey.


Suggested change

passkey for pairing, or :c:macro:`BT_PASSKEY_RAND` to generate a random passkey.

available when :kconfig:option:`CONFIG_BT_APP_PASSKEY` is enabled. The application can return a

random passkey for pairing, or :c:macro:`BT_PASSKEY_RAND` to the Host to generate a random passkey

instead.

Added a variant!

m-alperen-sener · 2025-10-20T13:02:17Z

include/zephyr/bluetooth/conn.h

+	 *        random and unique keys.
+	 *
+	 *  @param conn Connection where pairing is currently active.
+	 *  @return Passkey for pairing or BT_PASSKEY_RAND to generate a random passkey.


Suggested change

* @return Passkey for pairing or BT_PASSKEY_RAND to generate a random passkey.

* @return Passkey for pairing or BT_PASSKEY_RAND for a random passkey generated by the Host.

m-alperen-sener · 2025-10-20T13:02:40Z

subsys/bluetooth/host/Kconfig

+	help
+	  With this option enabled, the application will be able to provide passkeys for pairing
+	  using the app_passkey() callback.  If the application does not provide a passkey, a
+	  random passkey will be generated.


Suggested change

random passkey will be generated.

random passkey will be generated by the Host.

m-alperen-sener

I left the last comment to make it a bit more clear for user that host will keep generating random value. Up to you, just suggestions.

include/zephyr/bluetooth/conn.h

subsys/bluetooth/host/smp.c

HaavardRei · 2025-10-21T10:25:08Z

Resolved comments from @alwa-nordic offline, but changed the IO capabilities when using the app_passkey cb to support both BT_SMP_IO_KEYBOARD_DISPLAY (when defining the passkey_entry cb and app_passkey) and BT_SMP_IO_DISPLAY_ONLY (when defining just app_passkey)

Adds the BT_APP_PASSKEY Kconfig, which allows the application to provide passkeys for pairing using the new `app_passkey()` callback. This is an alternative to BT_FIXED_PASSKEY, which will be deprecated in a later commit. Signed-off-by: Håvard Reierstad <[email protected]>

The BT_FIXED_PASSKEY Kconfig option is being deprecated, and is replaced by BT_APP_PASSKEY. The reason for the deprecation is an upcoming errata, ES-24489, which mandates that a new passkey shall be generated for each pairing procedure. Signed-off-by: Håvard Reierstad <[email protected]>

Updates the bt shell API to use the new Kconfig option BT_APP_PASSKEY instead of BT_FIXED_PASSKEY as this is being deprecated. Signed-off-by: Håvard Reierstad <[email protected]>

sonarqubecloud · 2025-10-21T12:09:37Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

m-alperen-sener suggested changes Oct 16, 2025

View reviewed changes

alwa-nordic reviewed Oct 16, 2025

View reviewed changes

subsys/bluetooth/host/Kconfig Outdated Show resolved Hide resolved

HaavardRei force-pushed the host_fixed_passkey_deprecation branch 2 times, most recently from ee6a869 to 74e17dc Compare October 20, 2025 07:51

HaavardRei marked this pull request as ready for review October 20, 2025 07:57

zephyrbot added area: Bluetooth area: Tests Issues related to a particular existing or missing test area: Bluetooth Audio labels Oct 20, 2025

github-project-automation bot added this to Bluetooth LE Audio Oct 20, 2025

github-project-automation bot moved this to In Review in Bluetooth LE Audio Oct 20, 2025

zephyrbot added area: Bluetooth Host Bluetooth Host (excluding BR/EDR) Release Notes To be mentioned in the release notes labels Oct 20, 2025

zephyrbot requested review from PavelVPV, Thalley, asbjornsabo, babrsn, cvinayak, fredrikdanebjer, hermabe, jhedberg, jthm-ot, larsgk, niym-ot, rugeGerritsen and sjanc October 20, 2025 07:59

zephyrbot assigned jhedberg and alwa-nordic Oct 20, 2025

HaavardRei force-pushed the host_fixed_passkey_deprecation branch from 74e17dc to c27861a Compare October 20, 2025 08:15

zephyrbot requested review from alwa-nordic and cfriedt October 20, 2025 08:17

zephyrbot requested a review from nashif October 20, 2025 08:17

HaavardRei force-pushed the host_fixed_passkey_deprecation branch 4 times, most recently from de1595b to 7a11bbb Compare October 20, 2025 12:03

PavelVPV reviewed Oct 20, 2025

View reviewed changes

subsys/bluetooth/host/smp.c Outdated Show resolved Hide resolved

subsys/bluetooth/host/smp.c Outdated Show resolved Hide resolved

HaavardRei force-pushed the host_fixed_passkey_deprecation branch 2 times, most recently from 8c38f22 to faf7645 Compare October 20, 2025 12:18

PavelVPV reviewed Oct 20, 2025

View reviewed changes

subsys/bluetooth/host/smp.c Outdated Show resolved Hide resolved

m-alperen-sener suggested changes Oct 20, 2025

View reviewed changes

HaavardRei force-pushed the host_fixed_passkey_deprecation branch from faf7645 to a3fc7d7 Compare October 20, 2025 12:57

PavelVPV previously approved these changes Oct 20, 2025

View reviewed changes

m-alperen-sener reviewed Oct 20, 2025

View reviewed changes

m-alperen-sener approved these changes Oct 20, 2025

View reviewed changes

HaavardRei dismissed PavelVPV’s stale review via 358fc38 October 20, 2025 13:11

HaavardRei force-pushed the host_fixed_passkey_deprecation branch from a3fc7d7 to 358fc38 Compare October 20, 2025 13:11

PavelVPV previously approved these changes Oct 20, 2025

View reviewed changes

alwa-nordic requested changes Oct 20, 2025

View reviewed changes

include/zephyr/bluetooth/conn.h Show resolved Hide resolved

include/zephyr/bluetooth/conn.h Show resolved Hide resolved

include/zephyr/bluetooth/conn.h Show resolved Hide resolved

subsys/bluetooth/host/smp.c Show resolved Hide resolved

HaavardRei dismissed PavelVPV’s stale review via 91c8cc9 October 21, 2025 10:25

HaavardRei force-pushed the host_fixed_passkey_deprecation branch from 358fc38 to 91c8cc9 Compare October 21, 2025 10:25

zephyrbot requested a review from alwa-nordic October 21, 2025 10:27

HaavardRei added 3 commits October 21, 2025 13:42

Bluetooth: Host: shell: Don't use BT_FIXED_PASSKEY

5b1b804

Updates the bt shell API to use the new Kconfig option BT_APP_PASSKEY instead of BT_FIXED_PASSKEY as this is being deprecated. Signed-off-by: Håvard Reierstad <[email protected]>

HaavardRei force-pushed the host_fixed_passkey_deprecation branch from 91c8cc9 to 5b1b804 Compare October 21, 2025 11:42

alwa-nordic approved these changes Oct 21, 2025

View reviewed changes

PavelVPV approved these changes Oct 21, 2025

View reviewed changes

	* 6 digits. The application shall return the passkey for pairing, or BT_PASSKEY_RAND to
	* The valid range of passkeys is 0 - 999999. The application shall return the passkey for pairing, or BT_PASSKEY_RAND to

-  passkey for pairing, or :c:macro:`BT_PASSKEY_RAND` to generate a random passkey.
+  available when :kconfig:option:`CONFIG_BT_APP_PASSKEY` is enabled. The application can return a
+  random passkey for pairing, or :c:macro:`BT_PASSKEY_RAND` to the Host to generate a random passkey
+  instead.

	* @return Passkey for pairing or BT_PASSKEY_RAND to generate a random passkey.
	* @return Passkey for pairing or BT_PASSKEY_RAND for a random passkey generated by the Host.

	random passkey will be generated.
	random passkey will be generated by the Host.

Bluetooth: Host: deprecate CONFIG_BT_FIXED_PASSKEY #97597

Are you sure you want to change the base?

Bluetooth: Host: deprecate CONFIG_BT_FIXED_PASSKEY #97597

Conversation

HaavardRei commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-alperen-sener left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PavelVPV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m-alperen-sener Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

m-alperen-sener Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

HaavardRei Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

m-alperen-sener Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

m-alperen-sener Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

m-alperen-sener left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HaavardRei commented Oct 21, 2025

Uh oh!

sonarqubecloud bot commented Oct 21, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HaavardRei commented Oct 15, 2025 •

edited

Loading