Skip to content

modules: CMakeLists: Update LVGL to 9.4.0 #97599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

modules: CMakeLists: Update LVGL to 9.4.0 #97599

wants to merge 3 commits into from
+203 −145

Conversation

faxe1008
Copy link
Contributor

Update LVGL CMakeLists for latest release.

@faxe1008 faxe1008 force-pushed the lvgl_v940_prep branch 2 times, most recently from 3243de4 to a34a8c4 Compare October 15, 2025 15:00
@github-actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
lvgl zephyrproject-rtos/lvgl@b03edc8 (zephyr_2025_06_11) zephyrproject-rtos/lvgl#68 zephyrproject-rtos/lvgl#68/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-lvgl DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 15, 2025
@faxe1008 faxe1008 force-pushed the lvgl_v940_prep branch 2 times, most recently from f3eafd5 to 59c8fb7 Compare October 15, 2025 15:10
@faxe1008 faxe1008 marked this pull request as ready for review October 16, 2025 13:51
@zephyrbot zephyrbot added area: Samples Samples area: LVGL Light and Versatile Graphics Library Support labels Oct 16, 2025
@faxe1008
Copy link
Contributor Author

Ready for testing, will update the module PR to the proper v9.4 version as soon as it is available.

@faxe1008 faxe1008 changed the title modules: CMakeLists: Update LVGL to 9.3.x modules: CMakeLists: Update LVGL to 9.4.0 Oct 16, 2025
@faxe1008
Copy link
Contributor Author

v9.4.0 is officially tagged, updated the module PR accordingly.

uLipe
uLipe previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@uLipe uLipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great the VGLite kernel drivers were added as well, thank you @faxe1008 !

@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 17, 2025
@faxe1008
Copy link
Contributor Author

@uLipe found that the osal was now missing lv_sleep_ms which led me to fixing the test depedencies and the thread deletion logic.

@uLipe
Copy link
Member

uLipe commented Oct 18, 2025

Ahh yeah the sleep_ms at the osal was just introduced, I missed the Zephyr osal is outside from LVGL.

@dkalowsk dkalowsk added this to the v4.3.0 milestone Oct 21, 2025
VynDragon
VynDragon approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@VynDragon VynDragon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran my usages, and built and ran samples, and LGTM.

@everedero
Copy link
Contributor

It works on st25dv_mb1283_disco target (after reverting commit #011a357, see #98029).

pdgendt
pdgendt requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest file change and related changes to modules/lvgl/CMakeLists.txt need to be done in a single commit, otherwise the git history isn't bisectable because the version in between does not compile.

Not sure about the other two fix commits as well.

Rendering looks good!

@faxe1008
Copy link
Contributor Author

Hmm not sure, actually. I mean it makes sense, for bisectability, but I separated the commits in the past as well. Do you combine them for nanopb as well?

@pdgendt
Copy link
Contributor

pdgendt commented Oct 22, 2025

Hmm not sure, actually. I mean it makes sense, for bisectability, but I separated the commits in the past as well. Do you combine them for nanopb as well?

Yes, it should be done like that.

@faxe1008
manifest: Update LVGL to v9.4
84d52cf 
Update the west yaml to point to the new LVGL version.
Update CMakeLists and samples accordingly.

Signed-off-by: Fabian Blatz <[email protected]>
@faxe1008
tests: lib: gui: lvgl: Add missing DYNAMIC_THREAD dependency
ccd4d46 
This patch adds a CONFIG_THREAD_STACK_INFO to properly enable
CONFIG_DYNAMIC_THREAD.

Signed-off-by: Fabian Blatz <[email protected]>
@faxe1008
modules: lvgl: Fix thread deletion in OSAL
581376a 
Do not delete the thread from within the thread callback function,
secure thread_delete against trying to delete a terminated thread.

Signed-off-by: Fabian Blatz <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JarmouniA
JarmouniA approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on STM32H750B-DK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdgendt pdgendt pdgendt approved these changes

@VynDragon VynDragon VynDragon approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@uLipe uLipe uLipe left review comments

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

Assignees

@faxe1008 faxe1008

Labels

area: LVGL Light and Versatile Graphics Library Support area: Samples Samples area: Tests Issues related to a particular existing or missing test DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-lvgl

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

8 participants

@faxe1008 @uLipe @everedero @pdgendt @VynDragon @JarmouniA @dkalowsk @zephyrbot