drivers: clock: stm32: Move the MSI init after the LSE init #97622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
nordic-krch
etienne-lms
reviewed
Oct 16, 2025
|
|
||
| #if STM32_MSI_PLL_MODE | ||
| /* Check for LSE to be ready since its mandatory for MSI PLL mode */ | ||
| while (LL_RCC_LSE_IsReady() != 1) { |
There was a problem hiding this comment.
I guess this means STM32_LSE_ENABLED should be set. If so, a build error would be welcome (and in that case, this loop is already implemented above).
If some SoC support LSE not being enabled by Zephyr because handled from another core, when it makes sense to test it is enabled (and ready). But in that case, maybe need some kind of timeout here to not blindly wait endlessly here.
There was a problem hiding this comment.
I removed the loop and added a build error instead
Moved the MSI init after the LSE init to respect the initialization flow of the MSI PLL mode that need LSE to be enabled and ready. Signed-off-by: Julien Racki <[email protected]>
|
erwango
approved these changes
Oct 20, 2025
mathieuchopstm
approved these changes
Oct 21, 2025
| z_stm32_hsem_unlock(CFG_HW_RCC_SEMID); | ||
| } | ||
|
|
||
| #if defined(STM32_MSI_ENABLED) |
There was a problem hiding this comment.
Nit: add a comment about MSI needing to come after LSE due to PLL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the MSI init after the LSE init to respect the initialization flow of the MSI PLL mode that need LSE to be enabled and ready
see the RM0394 - STM32L41xxx/42xxx/43xxx/44xxx/45xxx/46xxx advanced Arm®-based 32-bit MCUs
Also added a check before enabling PLL Mode for MSI by making sure LSE is ready.
Fixes #96849