riscv: pmp: Use XLEN-derived PMPCFG_STRIDE for array sizing #97659
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Architectures
area: RISCV
zephyrbot
requested review from
VynDragon,
dcpleung,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
nashif,
npitre,
tgorochowik and
ycsin
Replace `sizeof(unsigned long)` with `PMPCFG_STRIDE` (defined as `__riscv_xlen / 8`) for dimensioning PMP configuration register arrays (`pmpcfg_regs`). The size of PMP configuration registers should be derived directly from the target architecture's XLEN. Using `sizeof(unsigned long)` can cause size mismatches, particularly with static analysis tools like SonarQube. These tools might assume a host-specific size for `unsigned long`, leading to spurious out-of-bounds access warnings when analyzing code for different RISCV base architectures (e.g., RV32 vs. RV64). This change ensures the array sizing is correctly and consistently tied to the target's register width (XLEN). Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
fix_stride
branch
from
bd4b72b to
5ae9e09
Compare
|
jimmyzhe
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
sizeof(unsigned long)withPMPCFG_STRIDE(defined as__riscv_xlen / 8) for dimensioning PMP configuration register arrays (pmpcfg_regs).The size of PMP configuration registers should be derived directly from the target architecture's XLEN. Using
sizeof(unsigned long)can cause size mismatches, particularly with static analysis tools like SonarQube. These tools might assume a host-specific size forunsigned long, leading to spurious out-of-bounds access warnings when analyzing code for different RISCV base architectures (e.g., RV32 vs. RV64).This change ensures the array sizing is correctly and consistently tied to the target's register width (XLEN).