drivers: counter: max32: Fix prescaler configuration #97711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
galak,
microbuilder,
nordic-krch,
ozersa and
yasinustunerg
ozersa
reviewed
Oct 16, 2025
Comment on lines
-249
to
-254
| if (prescaler_index == 0) { | ||
| tmr_cfg.pres = TMR_PRES_1; /* TMR_PRES_1 is 0 */ | ||
| } else { | ||
| /* TMR_PRES_2 is 1<<X */ | ||
| tmr_cfg.pres = TMR_PRES_2 + (prescaler_index - 1); | ||
| } |
There was a problem hiding this comment.
If i did not miss something, seems logic simply can be
tmr_cfg.pres = prescaler_index * TMR_PRES_2;
There was a problem hiding this comment.
You are right, thanks.
There was a problem hiding this comment.
Could you propagate it to pwm_max32.c ?
ttmut
force-pushed
the
fix/counter_max32
branch
2 times, most recently
from
a2a8a80 to
2267dc4
Compare
MaureenHelm
reviewed
Oct 17, 2025
The existing formula assumed prescaler enumerations were consecutive, which led to incorrect values being passed to HAL functions. Update the code to calculate correct prescaler enumerations. Signed-off-by: Furkan Akkiz <[email protected]>
Replace the look-up table used to obtain the prescaler enumeration with a simple multiplication. Signed-off-by: Tahsin Mutlugun <[email protected]>
ttmut
force-pushed
the
fix/counter_max32
branch
from
2267dc4 to
5902b57
Compare
|
Commit message has been fixed and the change has been propagated to |
|
ozersa
approved these changes
Oct 20, 2025
MaureenHelm
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the prescaler configuration formula. Prescaler enumerations are not consecutive numbers, so the existing formula does not work as expected.
Add prescaler enums into a lookup table and set counter prescaler from this array using prescaler_index parameter.This is the same fix introduced in #95409, but for the counter driver.