drivers: dma: stm32: avoid clear TE in case of hal_override #97741
Conversation
If hal_override is set, avoid reporting an error and clear the transfer error (TE) bit so that HAL code can properly handle it. Signed-off-by: Alain Volmat <[email protected]>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
teburd
| /* Let HAL DMA handle flags on its own */ | ||
| if (!stream->hal_override) { | ||
| LOG_ERR("Transfer Error."); | ||
| stream->busy = false; | ||
| dma_stm32_dump_stream_irq(dev, id); | ||
| dma_stm32_clear_stream_irq(dev, id); | ||
| } |
There was a problem hiding this comment.
Maybe we should log nonetheless?
| /* Let HAL DMA handle flags on its own */ | |
| if (!stream->hal_override) { | |
| LOG_ERR("Transfer Error."); | |
| stream->busy = false; | |
| dma_stm32_dump_stream_irq(dev, id); | |
| dma_stm32_clear_stream_irq(dev, id); | |
| } | |
| LOG_ERR("Transfer Error."); | |
| if (!stream->hal_override) { | |
| /* Let HAL DMA handle flags on its own */ | |
| stream->busy = false; | |
| dma_stm32_dump_stream_irq(dev, id); | |
| dma_stm32_clear_stream_irq(dev, id); | |
| } |
There was a problem hiding this comment.
Hum, considering that in case of HAL_OVERRIDE is being use, the Zephyr DMA framework is mainly use for resource handling rather than DMA functionaly speaking, I do not think that in such condition we should LOG anything here. If that's the HAL which is handling the DMA control, error checking etc, let's let it fully handle (aka configure, error handling etc).
Don't misunderstand me, I am not saying that we should bypass all and forever the Zephyr DMA framework ;) however in current implementation I do not see much merit to have the Zephyr DMA log this message. At least in case of DCMI, we have the callback in place to also get notification of transfer error. I suppose that's also the same thing for other drivers relying on HAL_OVERRIDE.
|
In case of hal_override, we might want to also avoid doing the flag clear in case of FiFo error done by the dma_stm32_v1.c. |
In case of using HAL_OVERRIDE, avoid clearing the FIFO ERROR flag before calling the HAL DMA IrqHandler so that the HAL DMA code handling can be used. Signed-off-by: Alain Volmat <[email protected]>
avolmat-st
dismissed stale reviews from mathieuchopstm and erwango
via
445302d
|
I added a new commit to also avoid clear of the FIFO ERROR flag in case of using HAL_OVERRIDE. |
|
4 participants
If hal_override is set, avoid reporting an error and clear the transfer error (TE) bit so that HAL code can properly handle it.