drivers: haptics: Add Shell support for haptics drivers #97744
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds shell command support for the haptics subsystem, allowing developers to interact with haptic devices through the command line interface. The implementation exposes the existing haptics_start_output and haptics_stop_output APIs through shell commands.
- Adds a new shell interface with
startandstopcommands for haptic devices - Provides dynamic device name completion for haptics-compatible devices
- Includes proper Kconfig option to enable/disable the shell functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| drivers/haptics/haptics_shell.c | New shell command implementation with start/stop operations and device filtering |
| drivers/haptics/Kconfig | Adds HAPTICS_SHELL configuration option dependent on SHELL |
| drivers/haptics/CMakeLists.txt | Conditionally compiles the shell module when enabled |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Expose the haptics API through a shell interface. Tested locally with dummy haptics driver. Signed-off-by: Liam Ogletree <[email protected]>
Liam-Ogletree
force-pushed
the
drivers_haptics_shell
branch
from
910e074 to
bf5f793
Compare
pdgendt
previously approved these changes
Oct 17, 2025
|
Might need a release note entry for * :kconfig:option:`CONFIG_HAPTICS_SHELL` |
Added -- thanks for the feedback! |
pdgendt
approved these changes
Oct 21, 2025
Add line documenting CONFIG_HAPTICS_SHELL in 4.3 release notes. Signed-off-by: Liam Ogletree <[email protected]>
Liam-Ogletree
force-pushed
the
drivers_haptics_shell
branch
from
1c8959c to
2382670
Compare
rriveramcrus
approved these changes
Oct 21, 2025
kartben
approved these changes
Oct 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the haptics API (
haptics_start_output,haptics_stop_output) through a shell interface. Tested locally with dummy haptics driver.