Skip to content

usb: usdc: BL61x Device HS USB #97750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

usb: usdc: BL61x Device HS USB #97750

wants to merge 3 commits into from
+1,531 −0

Conversation

VynDragon
Copy link
Contributor

@VynDragon VynDragon commented Oct 16, 2025 •
edited
Loading

It does device at high-speed speeds.

Caveat: controller does host, this does not do host.

@VynDragon VynDragon mentioned this pull request Oct 17, 2025
Open
@VynDragon VynDragon changed the title Bl61x usb usb: usdc: BL61x Device HS USB Oct 17, 2025
@VynDragon VynDragon force-pushed the bl61x_usb branch 4 times, most recently from 662579f to f771808 Compare October 17, 2025 21:46
@josuah josuah self-requested a review October 17, 2025 23:33
josuah
josuah reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish to do another round of review when I get back home, also run USB3CV compliance tool which will be good at spotting bugs.

Though it sounds like ready for review to me.
Thank you!

@josuah
Copy link
Contributor

josuah commented Oct 18, 2025 •
edited
Loading

Zephyr host not ready yet either... (>_<')
The host driver API seems a bit simpler.

@VynDragon
Copy link
Contributor Author

Thanks for the review.

Zephyr host not ready yet either... (>_<') The host driver API seems a bit simpler.

What would be the proper naming scheme? should I name this driver 'udc' instead of usb and the host one 'uhc'?

@josuah
Copy link
Contributor

josuah commented Oct 18, 2025

I think you are right, to follow the UDC (USB Device Controller) acronym, BL61x USB controller device driver could eventually become BL61x USB device controller driver.

@VynDragon VynDragon force-pushed the bl61x_usb branch 2 times, most recently from da3285c to e7f5f3b Compare October 18, 2025 02:37
@VynDragon
Copy link
Contributor Author

And one other caveat before this is ready, this will need to add a new board, because the current bl61x board ai-m62-12f has NO usb at all going out the module so it cant support USB. Liekly this will be sipeed m0s, but it could also be added to qcc744_evk if it's merged very fast

@VynDragon
Copy link
Contributor Author

Ah no wait it does have them...

@VynDragon VynDragon marked this pull request as ready for review October 18, 2025 16:17
@VynDragon VynDragon requested a review from josuah October 18, 2025 16:17
josuah
josuah previously approved these changes Oct 18, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you I did not find anything missing!
I added a few extra notes if wanting to anticipate the review of USB maintainers, not 100% sure this is going to be requested.

josuah
josuah reviewed Oct 19, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it's going to be enforced to have all of them marked as const (not part of Zephyr coding style, just the style in USB), but in case you wanted a TODO list here we go.

@josuah
Copy link
Contributor

josuah commented Oct 19, 2025

I think the next step is basically wait that the maintainers' review queue clears out.

If it takes long and "ping" don't help, the workaround is west patch gh-fetch --pull-request 97750 to maintain this PR as a local patch until it's merged.

@VynDragon
Copy link
Contributor Author

west patch gh-fetch --pull-request 97750

i didnt know about that and manually git fetched and cherry picked PR

@VynDragon
usb: udc: Introduce bl61x UDC driver
5450b6a 
Adds a device mode driver for BL61x

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
dts: Add BL61x USB device binding
b60230c 
Adds the binding to enable the USB controller

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
boards: bflb: Add USB to ai_m62_12f
ad3fbc6 
This is necessary to have a board testing the USB driver,
however the board doesn't have a USB plug for it,
but the pins are available

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
Copy link
Contributor Author

ok did all the ones that worked i think and a few more

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josuah josuah josuah approved these changes

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@katsuster katsuster Awaiting requested review from katsuster

@kgugala kgugala Awaiting requested review from kgugala

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@mgielda mgielda Awaiting requested review from mgielda

@npitre npitre Awaiting requested review from npitre

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

@tmon-nordic tmon-nordic Awaiting requested review from tmon-nordic

@ycsin ycsin Awaiting requested review from ycsin

At least 2 approving reviews are required to merge this pull request.

Assignees

@jfischer-no jfischer-no

Labels

area: Boards/SoCs area: Devicetree Bindings area: RISCV RISCV Architecture (32-bit & 64-bit) area: USB Universal Serial Bus platform: Bouffalo Lab

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VynDragon @josuah @jfischer-no @zephyrbot