Skip to content

Conversation

@heronet
Copy link
Contributor

@heronet heronet commented Oct 17, 2025

  • Add board Image
  • Update board name and symbols to match other boards

And because they have multiple H5 boards now

@heronet heronet force-pushed the boards/weact/fix-weact-stm32h562-core-board branch from 1900c43 to 0f77079 Compare October 17, 2025 00:28
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Oct 17, 2025
@heronet
Copy link
Contributor Author

heronet commented Oct 17, 2025

I renamed the board in release notes too as it was causing the checks to fail. Please let me know if I wan not allowed to do that

Copy link
Contributor

@str4t0m str4t0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be two boards from WeAct with a STM32H562 SoC called Core board, so it is not really expressive either? I think you should additionally include 64Pin/100Pin in the name or alternatively more from the Soc name.

@heronet
Copy link
Contributor Author

heronet commented Oct 17, 2025

There seem to be two boards from WeAct with a STM32H562 SoC called Core board, so it is not really expressive either? I think you should additionally include 64Pin/100Pin in the name or alternatively more from the Soc name.

Well they have the exact same 64 pin shaped board for 4 mcus (STM32F446RE, F405, F412, and H562) and they are all named similarly.
In some other families when they have 2 boards using the same MCU, they call the bigger one "LongBoard". Maybe the 100 pin one could be called Long Board or 100 pin when it is added? So that the base model remains base model and the newer one could be an "extended" model

@heronet heronet requested a review from str4t0m October 17, 2025 13:18
@str4t0m
Copy link
Contributor

str4t0m commented Oct 23, 2025

Hm, naming and consistency are really not a thing for WeAct. Nearly every board is called (Mini) Core board. No mather the formfactor or if they spin multiple boards with the same soc. So I don't want to block.
However it would be good to add an entry in boards/deprecated.cmake file.

@str4t0m str4t0m dismissed their stale review October 23, 2025 15:39

No strong feelings about this, and don't want to block.

@heronet heronet force-pushed the boards/weact/fix-weact-stm32h562-core-board branch from 0f77079 to cb28f13 Compare October 23, 2025 16:09
- Add board Image
- Update board name and symbols to match other boards

Signed-off-by: Siratul Islam <[email protected]>
@heronet heronet force-pushed the boards/weact/fix-weact-stm32h562-core-board branch from cb28f13 to 6a75607 Compare October 23, 2025 16:15
@heronet
Copy link
Contributor Author

heronet commented Oct 23, 2025

Hm, naming and consistency are really not a thing for WeAct. Nearly every board is called (Mini) Core board. No mather the formfactor or if they spin multiple boards with the same soc. So I don't want to block. However it would be good to add an entry in boards/deprecated.cmake file.

Yeah their naming is not the best. I added a some 7 of their boards recently. I tried to keep the naming similar to the existing ones. Now looking at the list a few of them don't quite fit the pattern. That's mainly the reason I'm trying to organize them a little. This board specially was too ambigous considering the amount of H5 boards they had and there being no board image.

I added the old name to boards/deprecated.cmake file.

@heronet
Copy link
Contributor Author

heronet commented Oct 23, 2025

I did a rebase because there were some conflicts

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants