-
Notifications
You must be signed in to change notification settings - Fork 8.1k
boards: arm: Update WeAct STM32H562 CoreBoard #97752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: arm: Update WeAct STM32H562 CoreBoard #97752
Conversation
1900c43 to
0f77079
Compare
|
I renamed the board in release notes too as it was causing the checks to fail. Please let me know if I wan not allowed to do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well they have the exact same 64 pin shaped board for 4 mcus (STM32F446RE, F405, F412, and H562) and they are all named similarly. |
|
Hm, naming and consistency are really not a thing for WeAct. Nearly every board is called (Mini) Core board. No mather the formfactor or if they spin multiple boards with the same soc. So I don't want to block. |
No strong feelings about this, and don't want to block.
0f77079 to
cb28f13
Compare
- Add board Image - Update board name and symbols to match other boards Signed-off-by: Siratul Islam <[email protected]>
cb28f13 to
6a75607
Compare
Yeah their naming is not the best. I added a some 7 of their boards recently. I tried to keep the naming similar to the existing ones. Now looking at the list a few of them don't quite fit the pattern. That's mainly the reason I'm trying to organize them a little. This board specially was too ambigous considering the amount of H5 boards they had and there being no board image. I added the old name to boards/deprecated.cmake file. |
|
I did a rebase because there were some conflicts |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
And because they have multiple H5 boards now