bluetooth: classic: HFP_AG: Fix early SCO connection req sending #97759
+142
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the audio connection, the SCO connection request will be sent before the response "OK" to AT command "AT+BCS" is issued. It causes the issue that the HFP HF cannot response the SCO connection request with the correct codec. Then the SCO connection cannot be established properly. Put all processing into the same context, thus avoiding non-sequential execution caused by the different priorities of different threads. Add a flag `BT_HFP_AG_AT_PROCESS` to flag the AT command is being processed. When the flag `BT_HFP_AG_AT_PROCESS` is set, put the pending executions into temp list `tx_submit_pending`. After the AT response `OK` or `ERROR` has been sent, move the pending executions from `tx_submit_pending` to `tx_pending`. Signed-off-by: Lyle Zhu <[email protected]>
zephyrbot
added
area: Bluetooth
area: Bluetooth Classic
zephyrbot
requested review from
MarkWangChinese,
chengkai15,
gzh-terry,
jhedberg and
makeshi
|
makeshi
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the audio connection, the SCO connection request will be sent before the response "OK" to AT command "AT+BCS" is issued.
It causes the issue that the HFP HF cannot response the SCO connection request with the correct codec. Then the SCO connection cannot be established properly.
Put all processing into the same context, thus avoiding non-sequential execution caused by the different priorities of different threads.
Add a flag
BT_HFP_AG_AT_PROCESSto flag the AT command is being processed.When the flag
BT_HFP_AG_AT_PROCESSis set, put the pending executions into temp listtx_submit_pending. After the AT responseOKorERRORhas been sent, move the pending executions fromtx_submit_pendingtotx_pending.