riscv: Make static ROM PMP entry conditional on MEM_ATTR #97763
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsammoura1980
force-pushed
the
disable_default_rom
branch
from
b1ff246 to
bb38256
Compare
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
npitre,
tgorochowik and
ycsin
fsammoura1980
force-pushed
the
disable_default_rom
branch
2 times, most recently
from
c1d2db4 to
9e080cf
Compare
The static ROM PMP entry is redundant when CONFIG_MEM_ATTR is enabled, as the memory attributes subsystem manages PMP regions dynamically via Device Tree. Add CONFIG_ENABLE_DEFAULT_ROM_PMP to disable the entry in this case, preventing potential conflicts. Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
disable_default_rom
branch
from
9e080cf to
06fa848
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static ROM PMP entry is redundant when
CONFIG_MEM_ATTRis enabled, as the memory attributes subsystem manages PMP regions dynamically via Device Tree.Add
CONFIG_ENABLE_DEFAULT_ROM_PMPto disable the entry in this case, preventing potential conflicts.