stm32wba : ble-802.15.4 concurrent mode integration #97773

vtardy-st · 2025-10-17T08:13:38Z

Integration of the BLE-802.15.4 concurrent mode on stm32wba based on CubeWBA release 1.7.0
Add new sample application ble-802.15.4 echo_client concurrent mode

github-actions · 2025-10-17T08:17:31Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_stm32	zephyrproject-rtos/hal_stm32@`286dd28`	zephyrproject-rtos/hal_stm32@`50fcec6` (`main`)	zephyrproject-rtos/[email protected]

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`	Blobs
hal_stm32				✏	6x ✏, 2x 🆕

⛔ DNM label due to: 1 project with metadata changes and 8 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

erwango

To be honest, it is not clear to me what the sample is supposed to demonstrate and how it should be used: Are 2 boards required ? What are the features supported ?

IMO, it's better to focus on a minimal sample for which the purpose is clear and where all the possible configurations have been validated.
Otherwise, we'll get users raising questions, using it with wrong purpose or raising issues on options that are not essential.

samples/boards/st/ble_802154/ble_hr_802154_echo_client/CMakeLists.txt

samples/boards/st/ble_802154/ble_hr_802154_echo_client/Kconfig

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/echo-client.c

samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst

erwango · 2025-12-01T11:06:45Z

samples/boards/st/bluetooth/ble_hr_802154_echo_client/README.rst

+************
+
+This sample has been tested on the STMicroelectonics NUCLEO-WBA65RI board
+(nucleo_wba65ri).


If 2 boards are required, please specify it here.

samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/echo-client.c

samples/boards/st/bluetooth/ble_hr_802154_echo_client/src/udp.c

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/udp.c

samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst

erwango

I had a build test and some more changes would be required:

Building the default configuration reports warnings:

warning: MAX_THREAD_BYTES (defined at arch/Kconfig:405) was assigned the value '3' but got the value
''. Check these unsatisfied dependencies: USERSPACE (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_MAX_THREAD_BYTES and/or look up
MAX_THREAD_BYTES in the menuconfig/guiconfig interface. The Application Development Primer, Setting
Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be helpful
too.


warning: NET_IF_MAX_IPV4_COUNT (defined at subsys/net/ip/Kconfig.ipv4:14) was assigned the value '3'
but got the value ''. Check these unsatisfied dependencies: NET_IPV4 (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_NET_IF_MAX_IPV4_COUNT and/or look up
NET_IF_MAX_IPV4_COUNT in the menuconfig/guiconfig interface. The Application Development Primer,
Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be
helpful too.

This should be fixed.

Buidling UDP=n/TCP=y reports errors. If only UDP is supported conditional code around UDP should be fixed (target_sources_ifdef(CONFIG_NET_UDP app PRIVATE src/udp.c) but maybe other a well)

Sample should be moved to samples/boards/st/bluetooth.

Finally, html rendered sample documentation could be read here: https://builds.zephyrproject.io/zephyr/pr/97773/docs/samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.html#stm32_ble_hr_802154_echo_client
Looks ok to me, but please check if enhancements could be made (clear enough for reader).

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/common.h

vtardy-st · 2025-12-03T10:07:50Z

In the prj.conf of the sample, many IPV4 configuration are setting while NET_IPV4 is setting to 'n'.
This implementation is herited from echo-client sample (samples/net/sockets/echo_client) in order to enable/disable IPV4/IPV6 through the prj.conf.

vtardy-st · 2025-12-04T14:30:02Z

Sample has been moved to samples/boards/st/bluetooth.

Add parameter to the link_layer_register_isr() to force or not the link layer isr registration in case of multiple function calls Update Bluetooth hci_stm32wba.c driver and IEEE 802.15.4 ieee802154_stm32wba.c driver accordingly. Signed-off-by: Vincent Tardy <[email protected]>

Integration of the BLE-802.15.4 concurrent mode on stm32wba. Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st · 2025-12-08T10:55:48Z

SonarCloud notifies issue related to CONTAINER_OF(), k_fifo_put()/_get() but I don't understand why

samples/boards/st/bluetooth/ble_hr_802154_echo_client/README.rst

jukkar

The echo-client sample is copied from network samples and just duplicates lot of code. It would better if we could add needed functionality to already existing sample instead of copying parts of it.

mathieuchopstm

otherwise LGTM

mathieuchopstm · 2025-12-08T14:27:10Z

samples/boards/st/bluetooth/ble_hr_802154_echo_client/CMakeLists.txt

+target_sources(                     app PRIVATE src/echo-client.c)
+target_sources(                     app PRIVATE src/app_ble.c)
+target_sources(                     app PRIVATE src/udp.c)


Suggested change

target_sources( app PRIVATE src/echo-client.c)

target_sources( app PRIVATE src/app_ble.c)

target_sources( app PRIVATE src/udp.c)

target_sources(app PRIVATE src/echo-client.c)

target_sources(app PRIVATE src/app_ble.c)

target_sources(app PRIVATE src/udp.c)

or

Suggested change

target_sources( app PRIVATE src/echo-client.c)

target_sources( app PRIVATE src/app_ble.c)

target_sources( app PRIVATE src/udp.c)

target_sources(app PRIVATE

src/echo-client.c

src/app_ble.c)

src/udp.c

)

mathieuchopstm · 2025-12-08T14:41:14Z

samples/boards/st/bluetooth/ble_hr_802154_echo_client/README.rst

+********
+
+The sample application implements a concurrent mode BLE - IEEE 802.15.4.
+Both wireless protocols Bluetooth |reg| Energy and IEEE 802.15.4 coexist :


Suggested change

Both wireless protocols Bluetooth |reg| Energy and IEEE 802.15.4 coexist :

Both wireless protocols Bluetooth |reg| Energy and IEEE 802.15.4 coexist:

mathieuchopstm · 2025-12-08T14:41:26Z

samples/boards/st/bluetooth/ble_hr_802154_echo_client/README.rst

+wait for the data to be sent back, and then verify it matches
+the data that was sent.
+The BLE part exposes the HR (Heart Rate) GATT Service. Once a device
+connects it will generate dummy heart-rate values.


Suggested change

connects it will generate dummy heart-rate values.

connects, it will generate dummy heart-rate values.

mathieuchopstm · 2025-12-08T14:43:52Z

soc/st/stm32/stm32wbax/hci_if/linklayer_plat_adapt.c

+		/* Ensure the IRQ is disabled before enabling it at run time */
+		irq_disable(RADIO_SW_LOW_INTR_NUM);
+
+		irq_connect_dynamic(RADIO_SW_LOW_INTR_NUM, RADIO_SW_LOW_INTR_PRIO,


Nit, maybe outside PR scope: any reason for using dynamic IRQs?

could be done in another PR

Add sample Bluetooth Heart Rate - 802154 Echo Client Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st · 2025-12-08T15:16:54Z

The echo-client sample is copied from network samples and just duplicates lot of code. It would better if we could add needed functionality to already existing sample instead of copying parts of it.

The possiblity was submitted earlier :
app_ble.c, echo-client.c and udp.c come from zephyr sample. At the beginning, we just modify echo-client.c to add ble functions and remove main() function in app_ble.c

Because there is no concurrent mode sample in zephyr samples section, we prefer to keep our sample in ST specific section

sonarqubecloud · 2025-12-08T15:33:16Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
63.3% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: STM32 ST Micro STM32 area: Boards/SoCs area: IEEE 802.15.4 area: Samples Samples area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth labels Oct 17, 2025

zephyrbot requested review from FRASTM, GeorgeCGV, HoZHel, Thalley, alwa-nordic, asm5878, benothmn-st, djiatsaf-st, erwango, etienne-lms, gautierg-st, hermabe, jhedberg, marwaiehm-st and mathieuchopstm October 17, 2025 08:15

zephyrbot assigned erwango Oct 17, 2025

github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Oct 17, 2025

hermabe removed their request for review October 17, 2025 08:23

vtardy-st marked this pull request as draft October 17, 2025 09:33

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 37cc906 to 17625f4 Compare October 17, 2025 10:02

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 3fde8f3 to fce5a3e Compare November 26, 2025 11:43

github-actions bot added the Binary Blobs Modified label Nov 26, 2025

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from fce5a3e to 05e6e49 Compare November 28, 2025 16:58

erwango requested changes Dec 1, 2025

View reviewed changes

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 05e6e49 to 3b20eeb Compare December 2, 2025 13:08

zephyrbot requested a review from erwango December 2, 2025 13:10

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 4988d73 to cae1152 Compare December 2, 2025 13:52

erwango requested changes Dec 2, 2025

View reviewed changes

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from cae1152 to da8327d Compare December 2, 2025 16:24

zephyrbot requested a review from erwango December 2, 2025 16:26

erwango requested changes Dec 3, 2025

View reviewed changes

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/common.h Outdated Show resolved Hide resolved

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from da8327d to 4ce9db5 Compare December 3, 2025 10:00

zephyrbot requested a review from erwango December 3, 2025 10:02

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 4ce9db5 to bfd0ccd Compare December 4, 2025 14:20

vtardy-st added 2 commits December 4, 2025 16:22

manifest: update hal_stm32 to support ble-ieee802152 concurrent mode

793eee4

Integration of the BLE-802.15.4 concurrent mode on stm32wba. Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from bfd0ccd to 1dfac3e Compare December 4, 2025 15:27

mathieuchopstm reviewed Dec 8, 2025

View reviewed changes

samples/boards/st/bluetooth/ble_hr_802154_echo_client/README.rst Outdated Show resolved Hide resolved

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 1dfac3e to 2408f30 Compare December 8, 2025 13:57

jukkar reviewed Dec 8, 2025

View reviewed changes

mathieuchopstm reviewed Dec 8, 2025

View reviewed changes

samples: boards: st: ble ieee802.15.4 concurrent mode

5f73e4a

Add sample Bluetooth Heart Rate - 802154 Echo Client Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 2408f30 to 5f73e4a Compare December 8, 2025 15:06

	Both wireless protocols Bluetooth \|reg\| Energy and IEEE 802.15.4 coexist :
	Both wireless protocols Bluetooth \|reg\| Energy and IEEE 802.15.4 coexist:

	connects it will generate dummy heart-rate values.
	connects, it will generate dummy heart-rate values.

stm32wba : ble-802.15.4 concurrent mode integration #97773

Are you sure you want to change the base?

stm32wba : ble-802.15.4 concurrent mode integration #97773

Conversation

vtardy-st commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vtardy-st commented Dec 3, 2025

Uh oh!

vtardy-st commented Dec 4, 2025

Uh oh!

vtardy-st commented Dec 8, 2025

Uh oh!

Uh oh!

jukkar left a comment

Choose a reason for hiding this comment

Uh oh!

mathieuchopstm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vtardy-st commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 8, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Oct 17, 2025 •

edited

Loading

vtardy-st commented Dec 8, 2025 •

edited

Loading