add I2S and EDMA support for IMX9 platform #97777

yananyang-nxp · 2025-10-17T08:48:25Z

add I2S and EDMA support for IMX9 platform

The depended PR below has been merged:
zephyrproject-rtos/hal_nxp#623

github-actions · 2025-10-17T08:49:13Z

Hello @yananyang-nxp, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-10-17T08:49:29Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`7bf6f09`	zephyrproject-rtos/hal_nxp@`846de35`	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dbaluta · 2025-10-22T06:56:40Z

drivers/clock_control/clock_control_mcux_ccm_rev2.c

 	case IMX_CCM_SAI3_CLK:
-		clock_root =  kCLOCK_Root_Sai3;
+		clock_root = kCLOCK_Root_Sai3;
 		break;


Please don't mix code cleanups with new feature. Create a separate patch for cleanups.

Fixed in the updated PR. Thanks!

dbaluta · 2025-10-22T06:59:34Z

drivers/i2s/i2s_mcux_sai.c

- * Copyright 2021,2023-2025 NXP Semiconductor INC.
+ * Copyright 2021,2023-2025 NXP
 * All rights reserved.
 *


Please don't mix fixes with new features.
For example here the correction of DMA burst length should be in a separate patch.

Please read this

https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements

Fixed in the updated PR, please help to have a review again. Thanks!

dbaluta · 2025-10-22T07:00:43Z

dts/arm64/nxp/nxp_mimx93_a55.dtsi

 	};

+	edma4_2: edma@42000000 {
+		compatible = "nxp,mcux-edma";


Please explain what is sai3_2 and edma4_2. Why such nodes are needed.

On the i.MX MPU platform, the original SAI and eDMA drivers were primarily designed for integration with Sound Open Firmware.
To support Zephyr's legacy I2S and eDMA functionality, we introduced new DTS nodes—eDMA_2 and I2S_2—which utilize the HAL EDMA and HAL I2S drivers.
Since the original eDMA driver does not incorporate the HAL EDMA layer, it is incompatible with the Zephyr MCUX I2S driver.

Zhiqiang-Hou · 2025-10-22T13:07:50Z

Updated:

fix the Bit Clock Swap setup logic in i2s_mcux_sai driver.
fixed CI failures.
reworked the patches to split the bug-fix, refine and new-feature changes into separate patches.

Zhiqiang-Hou · 2025-10-23T10:06:52Z

Updated:

fixed CI failure.
rebased the PR to resolve the conflict.
updated hal_nxp revision to include the depended code.

dleach02 · 2025-10-23T16:25:52Z

Not sure why the bot thinks blobs were added. No blobs added to HAL zephyrproject-rtos/hal_nxp#615

sonarqubecloud · 2025-10-24T03:33:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Update the hal_nxp revision to the imx91 EDMA support commit. Signed-off-by: Hou Zhiqiang <[email protected]>

Enable MMIO mapping in dma_mcux_edma driver Signed-off-by: Yanan Yang <[email protected]>

add SAI clock support for i.MX9 platform Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Jiafei Pan <[email protected]> Fix CI failure: LEADING_SPACE: please, no spaces at the start of a line Split code format fixing into a new patch Signed-off-by: Hou Zhiqiang <[email protected]>

Remove extra space between the '=' and rvalue. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

The burst length should be initialized with 'word_size_bits'. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

Change to use device model MMIO mapping APIs. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Jiafei Pan <[email protected]> Fix CI failures: Clean unused code Signed-off-by: Hou Zhiqiang <[email protected]>

Correct the type of num_of_bufs to uint32_t. Signed-off-by: Hou Zhiqiang <[email protected]>

When the platform has the Bit Clock Swap feature, enable it. Signed-off-by: Hou Zhiqiang <[email protected]>

Rework the driver to support i.MX9 platforms. Signed-off-by: Hou Zhiqiang <[email protected]> Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>

add add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

Zhiqiang-Hou · 2025-10-24T03:34:52Z

Updated:

rebased to resolve west.yml conflict.
change to update hal_nxp revision to the depended commit instead of the latest.

github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 17, 2025

zephyrbot added area: Clock Control area: DMA Direct Memory Access platform: NXP MPU platform: NXP NXP area: ARM64 ARM (64-bit) Architecture area: Boards/SoCs area: I2S labels Oct 17, 2025

zephyrbot requested review from EmilioCBen, JiafeiPan, MaochenWang1, PetervdPerk-NXP, ZhaoxiangJin, Zhiqiang-Hou, axelnxp, bperseghetti, dbaluta, decsny, dleach02, iuliana-prodan, manuargue, mmahadevan108 and yangbolu1991 October 17, 2025 08:50

zephyrbot assigned dleach02, mmahadevan108 and decsny Oct 17, 2025

dbaluta reviewed Oct 22, 2025

View reviewed changes

Zhiqiang-Hou force-pushed the imx9_i2s_edma branch from ee01c55 to bac888f Compare October 22, 2025 12:55

Zhiqiang-Hou force-pushed the imx9_i2s_edma branch 3 times, most recently from 1391413 to 3be8656 Compare October 23, 2025 09:56

github-actions bot added the Binary Blobs Modified label Oct 23, 2025

dleach02 removed DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Modified labels Oct 23, 2025

Zhiqiang-Hou force-pushed the imx9_i2s_edma branch from b718153 to 82c8755 Compare October 24, 2025 03:29

Zhiqiang-Hou and others added 14 commits October 24, 2025 11:33

west.yml: update hal_nxp revision

ca7f2e9

Update the hal_nxp revision to the imx91 EDMA support commit. Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: dma: dma_mcux_edma: enable MMIO mapping

b55c4f3

Enable MMIO mapping in dma_mcux_edma driver Signed-off-by: Yanan Yang <[email protected]>

drivers: mcux_ccm_rev2: fix code format

783f6e2

Remove extra space between the '=' and rvalue. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: i2s: mcux_sai: correct DMA burst length

a3e434b

The burst length should be initialized with 'word_size_bits'. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: i2s: i2s_mcux_sai: use device model MMIO mapping

00803b3

Change to use device model MMIO mapping APIs. Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Jiafei Pan <[email protected]> Fix CI failures: Clean unused code Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: i2s: mcux_sai: fix the type of var num_of_bufs

cb6f100

Correct the type of num_of_bufs to uint32_t. Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: i2s: mcux_sai: set the Bit Clock Swap on the feature enabled

5435554

When the platform has the Bit Clock Swap feature, enable it. Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: i2s: i2s_mcux_sai: add i.MX9 platform support

2e4f1f9

Rework the driver to support i.MX9 platforms. Signed-off-by: Hou Zhiqiang <[email protected]> Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>

dts: arm64: imx93: add sai3_2 and edma4_2 node for i2s_mcux_sai driver

24b1c29

add add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

boards: imx93_evk: add sai3_2 and edma4_2 node for i2s_mcux_sai driver

9ba7a99

add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

boards: frdm_imx93: add sai3_2 and edma4_2 node for i2s_mcux_sai driver

d376fa7

add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

dts: arm64: imx9131: add sai3_2 and edma4_2 node for i2s_mcux_sai driver

f2c8d09

add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]> Signed-off-by: Hou Zhiqiang <[email protected]>

boards: frdm_imx91: add sai3_2 and edma4_2 node for i2s_mcux_sai driver

82c8755

add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <[email protected]>

add I2S and EDMA support for IMX9 platform #97777

Are you sure you want to change the base?

add I2S and EDMA support for IMX9 platform #97777

Conversation

yananyang-nxp commented Oct 17, 2025 • edited by Zhiqiang-Hou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbaluta Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Zhiqiang-Hou Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dbaluta Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Zhiqiang-Hou Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dbaluta Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

yananyang-nxp Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Zhiqiang-Hou commented Oct 22, 2025

Uh oh!

Zhiqiang-Hou commented Oct 23, 2025

Uh oh!

dleach02 commented Oct 23, 2025

Uh oh!

sonarqubecloud bot commented Oct 24, 2025

Quality Gate passed

Uh oh!

Zhiqiang-Hou commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yananyang-nxp commented Oct 17, 2025 •

edited by Zhiqiang-Hou

Loading

github-actions bot commented Oct 17, 2025 •

edited

Loading