Support Retronix Sparrow Hawk board based on Renesas R-Car V4H SoC #97783

DuyDang007 · 2025-10-17T09:55:47Z

Hi everyone,

I would like to submit the code to support Retronix Sparrow Hawk board.

The board information can be found here:

https://www.renesas.com/en/support/partners/r-car-consortium/r-car-consortium-proactive-partner-list/rtx-sparrow-hawk?srsltid=AfmBOorxqVwVgVuRQ4Mi1N5FJYzQpdxNyP39oBwpRTHV3wtzNFtAVfCz

https://rcar-community.github.io/Sparrow-Hawk/index.html#introduction

Currently it supports only UART driver and confirmed with Hello World sample app. More features will be supported in the future

github-actions · 2025-10-17T09:56:25Z

Hello @DuyDang007, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

dts/arm/renesas/rcar/gen4/r8a779g0.dtsi

nordicjm · 2025-10-17T10:06:04Z

soc/renesas/rcar/rcar_gen4/Kconfig.defconfig.r8a779g0

+config ARCH
+	default "arm"


I removed this

nordicjm · 2025-10-17T10:07:15Z

boards/retronix/sparrowhawk_rcar_v4h/sparrowhawk_rcar_v4h_r8a779g0_r52_defconfig

+# Generic timer clock frequency in Hz
+CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=16666667


goes in soc Kconfig.defconfig and must come from dts property using functions

I moved it to Kconfig.defconfig.r8a779g0.

Could you explain "and must come from dts property using functions"? I see that the driver read from this config directly, not the dts

nordicjm · 2025-10-17T10:07:31Z

boards/retronix/sparrowhawk_rcar_v4h/sparrowhawk_rcar_v4h_r8a779g0_r52_defconfig

+CONFIG_FLASH_SIZE=0
+CONFIG_FLASH_BASE_ADDRESS=0x40040000
+


I think this board has been designed improperly, this is not correct

I deleted these configs. This board uses bootloader, not booting from flash. So, these configs are unused.

nordicjm · 2025-10-17T10:07:45Z

drivers/pinctrl/renesas/rcar/CMakeLists.txt

  zephyr_library_sources(pfc_r8a77951.c)
 elseif (CONFIG_SOC_R8A779F0_R52 OR CONFIG_SOC_R8A779F0_A55)
  zephyr_library_sources(pfc_r8a779f0.c)
+elseif (CONFIG_SOC_R8A779G0_R52)


no space between if and bracket in cmake

nordicjm · 2025-10-17T10:08:38Z

soc/renesas/rcar/rcar_gen4/soc.c

+
+#ifdef CONFIG_UART_CONSOLE
+/* Support early console log */
+int arch_printk_char_out(int _c)


why is this here at all?

At the beginning, there's no console log. I tried adding this. But now the UART console can work after removing this. Maybe another issue.

I deleted this file

nordicjm · 2025-10-17T10:08:52Z

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst

+Here are the current supported features:
+
+-----------+------------------------------+--------------------------------+
+| Interface | Driver/components            | Support level                  |
+===========+==============================+================================+
+| PINMUX    | pin-ctrl                     |                                |
+-----------+------------------------------+--------------------------------+
+| CLOCK     | clock_control                |                                |
+-----------+------------------------------+--------------------------------+
+| GPIO      | gpio                         | Not yet                        |
+-----------+------------------------------+--------------------------------+
+| UART      | uart                         | serial port-polling            |
+           +                              +                                +
+|           | FT2232H                      | serial port-interrupt          |
+-----------+------------------------------+--------------------------------+
+| I2C       | i2c                          | Not yet                        |
+-----------+------------------------------+--------------------------------+
+| Timer     | timer                        | Not yet                        |
+-----------+------------------------------+--------------------------------+
+| PWM       | pwm                          | Not yet                        |
+-----------+------------------------------+--------------------------------+
+| SPI       | spi                          | Not yet                        |
+-----------+------------------------------+--------------------------------+
+
+More features will be supported soon.


whole table to go, use hw directive

I updated it

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst

kartben · 2025-10-21T07:49:17Z

boards/retronix/sparrowhawk_rcar_v4h/doc/img/01_v4h_sparrow_hawk.jpg

please use the following webp / transparent bg / better quality image instead, name the same as board too so "sparrowhawk_rcar_v4h.webp"

Thank you for your comments.

I used this image

boards/retronix/index.rst

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst

boards/retronix/sparrowhawk_rcar_v4h/board.yml

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst

kartben

+1 for docs, thanks!

kartben · 2025-10-22T06:39:20Z

boards/retronix/sparrowhawk_rcar_v4h/sparrowhawk_rcar_v4h_r8a779g0_r52-pinctrl.dtsi

+	hscif1_data_tx_default: hscif1_data_tx_default {
+		pin = <PIN_MSIOF2_SYNC FUNC_HRX1>;
+	};
+	hscif1_data_rx_default: hscif1_data_rx_default {


Suggested change

hscif1_data_rx_default: hscif1_data_rx_default {

hscif1_data_rx_default: hscif1_data_rx_default {

Copilot

Pull Request Overview

This PR adds support for the Retronix Sparrow Hawk board based on the Renesas R-Car V4H SoC (r8a779g0) running on the Cortex-R52 processor. The implementation provides UART driver support and has been validated with the Hello World sample application.

Key Changes

Added SoC-level support for r8a779g0 with Cortex-R52 processor configuration
Implemented board-specific files for Sparrow Hawk including device tree, pinctrl, and documentation
Extended pinctrl and clock control drivers to support the new r8a779g0 SoC

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
soc/renesas/rcar/soc.yml	Added r8a779g0 SoC with r52 CPU cluster definition
soc/renesas/rcar/rcar_gen4/Kconfig.	Added Kconfig options and default configurations for r8a779g0_r52
soc/renesas/rcar/rcar_gen4/CMakeLists.txt	Added build configuration for r8a779g0_r52 target
include/zephyr/dt-bindings/pinctrl/renesas/*	Added pinctrl definitions and macros for r8a779g0
include/zephyr/dt-bindings/clock/*	Added clock controller bindings for r8a779g0
dts/bindings/vendor-prefixes.txt	Added retronix vendor prefix
dts/bindings/clock/*	Added YAML binding for r8a779g0 CPG MSSR
dts/arm/renesas/rcar/gen4/*	Added device tree includes for r8a779g0 SoC
drivers/pinctrl/renesas/rcar/*	Added pinctrl driver implementation for r8a779g0
drivers/clock_control/*	Added clock control driver for r8a779g0 CPG MSSR
boards/retronix/sparrowhawk_rcar_v4h/*	Added complete board support files including DTS, Kconfig, and documentation
boards/retronix/index.rst	Added Retronix vendor board index

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst

nordicjm · 2025-10-22T06:56:06Z

dts/arm/renesas/rcar/gen4/r8a779g0.dtsi

+		/* Using domain 0
+		 */


why does this comment need to space over 2 lines?

I fixed that.

By the way, I remove one pair of reg node since they have the same base address.

nordicjm · 2025-10-22T06:56:49Z

dts/arm/renesas/rcar/gen4/rcar_gen4_v4h_cr52.dtsi

+		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL
+					IRQ_DEFAULT_PRIORITY>,


the formatting of this is bad, put each value on a line each? e.g. <GIC_PPI 13 IRQ_TYPE_LEVEL IRQ_DEFAULT_PRIORITY>,

I fixed the alignment issues.

nordicjm · 2025-10-22T07:10:33Z

dts/arm/renesas/rcar/gen4/r8a779g0.dtsi

+		pfc: pin-controller@e6050000 {
+			compatible = "renesas,rcar-pfc";
+			reg = <0xe6050000 0x1d8>, <0xe6050800 0x1d8>,
+				  <0xe6058000 0x1d8>, <0xe6058800 0x1d8>,


bad alignment

nordicjm · 2025-10-22T07:28:18Z

soc/renesas/rcar/rcar_gen4/Kconfig.defconfig.r8a779g0

+
+# Arm Generic Timer frequency (Hz)
+config SYS_CLOCK_HW_CYCLES_PER_SEC
+	default 16666667


this needs to come from dts using a dt function

This config is used in arm_arch_timer.c for system tick. The driver read CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC value directly so I cannot make use of DT function.

In V4H SoC, 16.667MHz is the fixed frequency of Generic Timer

Then add a dts node for it as other SoCs do, it's hardware in the silicon

So, I will add the frequency value to its timer node like below:

rcar_gen4_v4h_cr52.dtsi:

timer { compatible = "arm,armv8-timer"; interrupt-parent = <&gic>; interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL IRQ_DEFAULT_PRIORITY>, <GIC_PPI 14 IRQ_TYPE_LEVEL IRQ_DEFAULT_PRIORITY>, <GIC_PPI 11 IRQ_TYPE_LEVEL IRQ_DEFAULT_PRIORITY>, <GIC_PPI 10 IRQ_TYPE_LEVEL IRQ_DEFAULT_PRIORITY>; + clock-frequency = <0xfe502b>; };

Is it correct?

clock-frequency = <16666667>; is fine, yes

and update the commit to get it from dt using the dt functions?

Do you mean update in arm_arch_timer.c? It affects other board build. I think it should be in another improvement PR

No, I mean to use the dt functions in the Kconfig file to get the value from devicetree, see https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/gd/gd32/gd32a50x/Kconfig.defconfig.gd32a503#L6 for an example

ah, I see. Sorry for misunderstood. I updated it

nordicjm · 2025-10-22T07:29:12Z

boards/retronix/sparrowhawk_rcar_v4h/sparrowhawk_rcar_v4h_r8a779g0_r52.dts

+};
+
+&gpio0 {
+	status = "disabled";


gpio should be disabled by default in the base dts file, why would it need to be disabled by the board?

Removed. It's a duplicated "disabled"

nordicjm · 2025-10-22T07:29:23Z

boards/retronix/sparrowhawk_rcar_v4h/sparrowhawk_rcar_v4h_r8a779g0_r52_defconfig

+
+# GPIO
+CONFIG_GPIO=n


should not be needed

kylebonnici · 2025-10-22T07:37:18Z

dts/arm/renesas/rcar/gen4/rcar_gen4_v4h_cr52.dtsi

Diff to address formatting issues

@@ -24,15 +24,15 @@ timer { compatible = "arm,armv8-timer"; interrupt-parent = <&gic>; interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL - IRQ_DEFAULT_PRIORITY>, - <GIC_PPI 14 IRQ_TYPE_LEVEL - IRQ_DEFAULT_PRIORITY>, - <GIC_PPI 11 IRQ_TYPE_LEVEL - IRQ_DEFAULT_PRIORITY>, - <GIC_PPI 10 IRQ_TYPE_LEVEL - IRQ_DEFAULT_PRIORITY>; + IRQ_DEFAULT_PRIORITY>, + <GIC_PPI 14 IRQ_TYPE_LEVEL + IRQ_DEFAULT_PRIORITY>, + <GIC_PPI 11 IRQ_TYPE_LEVEL + IRQ_DEFAULT_PRIORITY>, + <GIC_PPI 10 IRQ_TYPE_LEVEL + IRQ_DEFAULT_PRIORITY>; }; soc { interrupt-parent = <&gic>; @@ -44,9 +44,9 @@ gic: interrupt-controller@f0000000 { compatible = "arm,gic-v3", "arm,gic"; reg = <0xf0000000 0x1000>, - <0xf0100000 0x20000>; + <0xf0100000 0x20000>; interrupt-controller; #interrupt-cells = <4>; status = "okay"; };

Thanks for you suggestion. I updated it.

This causes the error with compliance check due to mixed tab and space indent:

CODE_INDENT: code indent should use tabs where possible File:dts/arm/renesas/rcar/gen4/rcar_gen4_v4h_cr52.dtsi Line:28 CODE_INDENT: code indent should use tabs where possible File:dts/arm/renesas/rcar/gen4/rcar_gen4_v4h_cr52.dtsi Line:29 CODE_INDENT: code indent should use tabs where possible File:dts/arm/renesas/rcar/gen4/rcar_gen4_v4h_cr52.dtsi Line:30

I changed the indent for better look and pass compliance check.

kylebonnici · 2025-10-22T07:38:40Z

dts/arm/renesas/rcar/gen4/r8a779g0.dtsi

Diff to address formatting issues

@@ -12,20 +12,20 @@ soc { pfc: pin-controller@e6050000 { compatible = "renesas,rcar-pfc"; reg = <0xe6050000 0x1d8>, <0xe6050800 0x1d8>, - <0xe6058000 0x1d8>, <0xe6058800 0x1d8>, - <0xe6060000 0x1d8>, <0xe6060800 0x1d8>, - <0xe6061000 0x1d8>, <0xe6061800 0x1d8>, - <0xe6068000 0x1d8>, <0xe6078000 0x0e8>; + <0xe6058000 0x1d8>, <0xe6058800 0x1d8>, + <0xe6060000 0x1d8>, <0xe6060800 0x1d8>, + <0xe6061000 0x1d8>, <0xe6061800 0x1d8>, + <0xe6068000 0x1d8>, <0xe6078000 0x0e8>; }; /* Using domain 0 */ cpg: clock-controller@e6150000 { compatible = "renesas,r8a779g0-cpg-mssr"; reg = <0xe6150000 0x8a4>, /* GPG */ - <0xe6150000 0x2e74>; /* Module standby, software reset */ + <0xe6150000 0x2e74>; /* Module standby, software reset */ #clock-cells = <2>; }; gpio0: gpio@e6050000 {

kartben · 2025-10-22T20:54:13Z

re-assigning to renesas r-car maintainer

Arm Generic Timer clock frequency is fixed per silicon. This value should be defined in DTS. Signed-off-by: Duy Dang <[email protected]>

This commit adds initial support for V4H SoC, Cortex-R52 core. Signed-off-by: Duy Dang <[email protected]>

This adds support for Retronix Sparrow Hawk board. The board is based on R-Car V4H v3.0 (R8A779G3) SoC. Signed-off-by: Duy Dang <[email protected]>

Support Clock Pulse Generator driver for V4H Signed-off-by: Duy Dang <[email protected]>

Add pin definition for R-Car V4H SoC. Signed-off-by: Duy Dang <[email protected]>

Adds a page for Retronix Sparrow Hawk in Supported boards. Signed-off-by: Duy Dang <[email protected]>

sonarqubecloud · 2025-10-24T12:02:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
34.8% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Devicetree Bindings platform: Renesas R-Car Renesas R-Car area: Pinctrl area: Boards/SoCs area: Clock Control labels Oct 17, 2025

zephyrbot requested review from gmarull, lorc, nordic-krch and xakep-amatop October 17, 2025 09:57

zephyrbot assigned nordic-krch Oct 17, 2025

DuyDang007 changed the title ~~Support Retronix Sparrow Hawk board on Renesas R-Car V4H SoC~~ Support Retronix Sparrow Hawk board based on Renesas R-Car V4H SoC Oct 17, 2025

nordicjm requested changes Oct 17, 2025

View reviewed changes

nordicjm requested a review from kartben October 17, 2025 10:09

DuyDang007 force-pushed the main_sparrowhawk branch from 78b2f0c to 2cd6abc Compare October 21, 2025 06:42

zephyrbot added the area: Devicetree label Oct 21, 2025

zephyrbot requested review from decsny, mbolivar and rruuaanng October 21, 2025 06:44

DuyDang007 requested a review from nordicjm October 21, 2025 06:52

kartben reviewed Oct 21, 2025

View reviewed changes

kartben requested changes Oct 21, 2025

View reviewed changes

DuyDang007 force-pushed the main_sparrowhawk branch from 2cd6abc to 1472554 Compare October 21, 2025 08:34

DuyDang007 requested a review from kartben October 21, 2025 08:36

DuyDang007 force-pushed the main_sparrowhawk branch from 1472554 to 1905b0e Compare October 22, 2025 02:51

kartben previously approved these changes Oct 22, 2025

View reviewed changes

kartben requested a review from Copilot October 22, 2025 06:40

Copilot AI reviewed Oct 22, 2025

View reviewed changes

boards/retronix/sparrowhawk_rcar_v4h/doc/sparrow_hawk_rcar_v4h_r52.rst Show resolved Hide resolved

DuyDang007 dismissed kartben’s stale review via 2729622 October 22, 2025 07:13

DuyDang007 force-pushed the main_sparrowhawk branch from 1905b0e to 2729622 Compare October 22, 2025 07:13

DuyDang007 force-pushed the main_sparrowhawk branch from 2729622 to 8c63905 Compare October 22, 2025 07:22

nordicjm requested changes Oct 22, 2025

View reviewed changes

kylebonnici suggested changes Oct 22, 2025

View reviewed changes

kartben assigned lorc and unassigned nordic-krch Oct 22, 2025

DuyDang007 force-pushed the main_sparrowhawk branch from 8c63905 to d79d2ca Compare October 23, 2025 06:02

dts: bindings: Add clock-frequency property to Arm v8 timer

73eb16c

Arm Generic Timer clock frequency is fixed per silicon. This value should be defined in DTS. Signed-off-by: Duy Dang <[email protected]>

DuyDang007 force-pushed the main_sparrowhawk branch from d79d2ca to b54cb40 Compare October 24, 2025 09:38

zephyrbot added the area: Timer Timer label Oct 24, 2025

zephyrbot requested review from andyross and teburd October 24, 2025 09:40

DuyDang007 requested review from kartben, kylebonnici and nordicjm October 24, 2025 09:42

DuyDang007 force-pushed the main_sparrowhawk branch from b54cb40 to 7d6ba30 Compare October 24, 2025 10:00

DuyDang007 added 5 commits October 24, 2025 18:25

soc: renesas: rcar: Support V4H SoC

acdbad6

This commit adds initial support for V4H SoC, Cortex-R52 core. Signed-off-by: Duy Dang <[email protected]>

board: rcar: Support Retronix Sparrow Hawk board

16ec18e

This adds support for Retronix Sparrow Hawk board. The board is based on R-Car V4H v3.0 (R8A779G3) SoC. Signed-off-by: Duy Dang <[email protected]>

driver: clock_control: Add V4H clock control driver

56fb0f0

Support Clock Pulse Generator driver for V4H Signed-off-by: Duy Dang <[email protected]>

driver: pinctrl: Add support R-Car V4H SoC

3fbf932

Add pin definition for R-Car V4H SoC. Signed-off-by: Duy Dang <[email protected]>

board: rcar: Add document for Retronix Sparrow Hawk board

1c122f8

Adds a page for Retronix Sparrow Hawk in Supported boards. Signed-off-by: Duy Dang <[email protected]>

DuyDang007 force-pushed the main_sparrowhawk branch from 7d6ba30 to 1c122f8 Compare October 24, 2025 11:34

		# Generic timer clock frequency in Hz
		CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=16666667

	hscif1_data_rx_default: hscif1_data_rx_default {

	hscif1_data_rx_default: hscif1_data_rx_default {

		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL
		IRQ_DEFAULT_PRIORITY>,

		CONFIG_FLASH_SIZE=0
		CONFIG_FLASH_BASE_ADDRESS=0x40040000


		# GPIO
		CONFIG_GPIO=n

Support Retronix Sparrow Hawk board based on Renesas R-Car V4H SoC #97783

Are you sure you want to change the base?

Support Retronix Sparrow Hawk board based on Renesas R-Car V4H SoC #97783

Conversation

DuyDang007 commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

kylebonnici Oct 22, 2025 •

edited

Loading