Skip to content

drivers: sensor: qdec_stm32: check counts/revoultion compile time #97788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

drivers: sensor: qdec_stm32: check counts/revoultion compile time #97788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions drivers/sensor/st/qdec_stm32/qdec_stm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,6 @@ static int qdec_stm32_initialize(const struct device *dev)
return retval;
}

if (dev_cfg->counts_per_revolution < 1) {
LOG_ERR("Invalid number of counts per revolution (%d)",
dev_cfg->counts_per_revolution);
return -EINVAL;
}

/* Ensure that the counter will always count up to a multiple of counts_per_revolution */
if (IS_TIM_32B_COUNTER_INSTANCE(dev_cfg->timer_inst)) {
max_counter_value = UINT32_MAX - (UINT32_MAX % dev_cfg->counts_per_revolution) - 1;
Expand All @@ -146,6 +140,9 @@ static DEVICE_API(sensor, qdec_stm32_driver_api) = {
};

#define QDEC_STM32_INIT(n) \
BUILD_ASSERT(DT_INST_PROP(n, st_counts_per_revolution) > 0, \
"Counts per revolution must be above 0"); \
\
BUILD_ASSERT(!(DT_INST_PROP(n, st_encoder_mode) & ~TIM_SMCR_SMS), \
"Encoder mode is not supported by this MCU"); \
\
Expand Down