drivers: usb: udc: stm32: fix FS mode on OTG_FS for STM32F4 series #97789
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On most parts of the STM32F4 series, when the OTG_HS controller is used in FS mode, the ULIP **low-power** clock must also be disabled for proper operation. This was done properly in an old version of the driver but was lost as part of refactoring[1]. Re-introduce ULPI low-power clock disable when OTG_HS is used in FS mode. [1] See commit e31ddec Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jfischer-no,
marwaiehm-st and
tmon-nordic
1 task
tmon-nordic
approved these changes
Oct 17, 2025
|
erwango
approved these changes
Oct 17, 2025
|
FTR, the MSC sample has been tested OK on |
|
@mathieuchopstm I can confirm that this fix works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most parts of the STM32F4 series, when the OTG_HS controller is used in FS mode, the ULIP low-power clock must also be disabled for proper operation. This was done properly in an old version of the driver but was lost as part of refactoring (commit e31ddec).
See Reference Manual extract:
Re-introduce ULPI low-power clock disable when OTG_HS is used in FS mode.
Fixes #97748