request reviews by changed area maintainer in maintainer file #97794
+145
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nashif
commented
Oct 17, 2025
nashif
commented
- ci: assigner: merge maintainer check into assigner workflow
- scripts: move set_assignee.py into scripts/ci
- scripts: set_assignee: request review from maintainers of changed areas
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/assigner.yml
Outdated
Check failure
Code scanning / CodeQL
Checkout of untrusted code in a privileged context Critical
.github/workflows/assigner.yml
Outdated
Check failure
Code scanning / CodeQL
Checkout of untrusted code in a privileged context Critical
nashif
force-pushed
the
topic/maintainer/review_by_m
branch
from
3aecae2 to
4f55fcc
Compare
.github/workflows/assigner.yml
Outdated
| FLAGS+=" -M MAINTAINERS.yml" | ||
| if [ "${{ github.event_name }}" = "pull_request_target" ]; then | ||
| FLAGS+=" -P ${{ github.event.pull_request.number }} --updated-manifest pr_west.yml" | ||
| FLAGS+=" -P ${{ github.event.pull_request.number }} --updated-manifest pr_west.yml" --updated-mantainer-file pr_MAINTAINERS.yml" |
There was a problem hiding this comment.
Probably meant to be:
Suggested change
| FLAGS+=" -P ${{ github.event.pull_request.number }} --updated-manifest pr_west.yml" --updated-mantainer-file pr_MAINTAINERS.yml" | |
| FLAGS+=" -P ${{ github.event.pull_request.number }} --updated-manifest pr_west.yml --updated-mantainer-file pr_MAINTAINERS.yml" |
?
Merge two workflows into one for code sharing an efficiency. Signed-off-by: Anas Nashif <[email protected]>
Scripts only used by CI, so move it into that directory. Signed-off-by: Anas Nashif <[email protected]>
Also request reviewes from maintainers of changes areas in the maintainer file. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/maintainer/review_by_m
branch
from
4f55fcc to
1f9469b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.