boards: shields: add support for MikroElektronika CAN FD 6 Click #97819
Conversation
zephyrbot
added
area: Shields
zephyrbot
requested review from
MaureenHelm,
alexanderwachter,
avisconti,
erwango,
henrikbrixandersen,
jfischer-no,
kartben,
martinjaeger,
nashif,
stephanosio and
str4t0m
| depends_on: | ||
| - arduino_spi | ||
| - arduino_gpio | ||
| extra_args: SHIELD=arduino_uno_click;mikroe_can_fd_6_click |
There was a problem hiding this comment.
Why do you need to bring in Arduino uno click in the mix?
There was a problem hiding this comment.
This is an additional safeguard.
MikroBus is much less widespread than Arduino. Arduino headers, on the other hand, can be found on virtually every evaluation system from the last 15-20 years, as long as the shape allows it (see all FRDM, Nucleo, or Discovery boards, and many more). This makes the MikroElektronika Arduino UNO Click shield one of the most important tools for working with one of the thousands of Click modules from MikroElektronika.
I think it is worth giving this shield stack special importance and validating it by upstream testing.
There was a problem hiding this comment.
Testing stacked shields is nice, but it should go into a dedicated test suite, not here.
There was a problem hiding this comment.
Yes, I got that feeling too. This additional "Shield Stack Test" is not well placed as "build_all" for drivers. Can anyone here suggest a good place for it? Perhaps an existing test suite?
If there isn't one yet, I would be very grateful for any suggestions on where such tests should be created under "tests/".
There was a problem hiding this comment.
Perhaps under tests/cmake/shields/?
There was a problem hiding this comment.
I cut out this issue to a new enhancement request in #97837 and remove the second test with mixed shield stack.
Add shield definition for the MikroElektronika CAN FD 6 Click shield, an mikroBUS compatible evaluation module for the TI TCAN4x5x CAN controller series. Signed-off-by: Stephan Linz <[email protected]>
Add the MikroE compile test for the TI TCAN4x5x series CAN controller driver. Signed-off-by: Stephan Linz <[email protected]>
This commit adds the MikroE CAN FD 6 Click shield under the same assignees as other of the CAN driver based shields. Signed-off-by: Stephan Linz <[email protected]>
Add myself as collaborator to help with reviews and occasional contributions for the CAN driver based peripherals, configurations, tests, samples and documentation. Signed-off-by: Stephan Linz <[email protected]>
rexut
force-pushed
the
tiacsys/contrib/shields/mikroe_can_fd_6_click
branch
from
cab91e9 to
acccce8
Compare
|
4 participants
The CAN FD 6 Click shield has a TI TCAN4550-Q1 automotive system basis chip (SBC) with integrated CAN FD controller via a SPI interface and a integrated high-speed CAN FD transceiver with up to 5 Mbps. More information about the shield can be found at: https://www.mikroe.com/can-fd-6-click
The shield definition activates the TI TCAN4x5x series driver and routes all additional GPIO signals to a suitable MikroBus header.
This pull request also includes necessary (possible) entries in the maintainer list and extends the "build all" test for CAN drivers.
Since I am currently unable to gauge how far additional board overlays at shield level are accepted by maintainers, or how the generally applicable project rules are defined in this regard, I am leaving such extensions out of this PR for the time being. If you are interested, please feel free to take a look at our branch: https://github.com/tiacsys/zephyr/commits/tiacsys/contrib/shields/mikroe_can_fd_6_click-boards/
The following pull requests are required to successfully perform the CAN API test on target without errors: